AkkomaGang/akkoma-fe
5
13
Fork 64
Code Issues 81 Pull requests 19 Projects Releases 1 Wiki Activity

added minimum space to empty timeline #400

Merged
floatingghost merged 2 commits from Riedler/akkoma-fe:empty-tl-minspace into develop 2024-06-17 21:40:56 +00:00
Conversation 1 Commits 2 Files changed 2 +4
Riedler commented 2024-06-16 14:04:10 +00:00
Contributor
Copy link

This improves how this particular edge case looks. Note that it does nothing for the inherent awkwardness of having nothing, followed by the "load more" button there.

theme before after
mine image image
default image image

Screenshots partially from https://donotsta.re/ and local branches, partially with width changes.

(part of changes from DNS#1)

This improves how this particular edge case looks. Note that it does nothing for the inherent awkwardness of having nothing, followed by the "load more" button there. | theme | before | after | | --- | --- | --- | | mine | ![image](/attachments/984fe616-e7b0-4875-8acb-85155882e42d) | ![image](/attachments/a5bb5d5f-9928-4351-93af-907a68828f2b) | | default | ![image](/attachments/1366f0bf-33e6-4843-954a-aea94a09a88b) | ![image](/attachments/8ff9db0f-fc6a-497c-9c80-f4840ab8c99d) | Screenshots partially from https://donotsta.re/ and local branches, partially with width changes. (part of changes from [DNS#1](https://git.sakamoto.pl/domi/akkoma-fe/pulls/1))
image.png
73 KiB
image.png
92 KiB
image.png
150 KiB
image.png
69 KiB
Riedler added 1 commit 2024-06-16 14:04:11 +00:00
added minimum space to empty timeline
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
49a850a1e9
Riedler added 1 commit 2024-06-16 14:12:31 +00:00
also set min height for other lists (e.g. follow requests), not just the timeline
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
f1058567b9
Oneric approved these changes 2024-06-17 00:43:40 +00:00
Oneric left a comment
Member
Copy link

I have no opinion on the visual change, but CSS seems straightforward enough and works as intended for me

I have no opinion on the visual change, but CSS seems straightforward enough and works as intended for me
floatingghost commented 2024-06-17 21:40:53 +00:00
Owner
Copy link

yeah coolio thankies~

yeah coolio thankies~
❤️ 1
floatingghost merged commit 24b9e350e2 into develop 2024-06-17 21:40:56 +00:00
floatingghost deleted branch empty-tl-minspace 2024-06-17 21:40:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Oneric
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#400
No description provided.
Delete branch "Riedler/akkoma-fe:empty-tl-minspace"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?