post_status_form: enable sync flush for watcher #414

Open

novenary wants to merge 1 commit from novenary/akkoma-fe:sticky-drafts into develop

novenary commented

2024-09-16 19:54:57 +00:00

First-time contributor

This fixes drafts not clearing after posting a reply.

Vue 3.3.11 changed watchers to stop firing after component unmount.
After posting a reply, the post form is removed, now causing the queued event to be discarded.
Synchronous flush causes the handler to be called immediately when changes happen, solving the problem.

See: https://github.com/vuejs/core/pull/7181
See: 80e2128d52
Fixes: a7dea2f70f
Fixes: #413

This fixes drafts not clearing after posting a reply. Vue 3.3.11 changed watchers to stop firing after component unmount. After posting a reply, the post form is removed, now causing the queued event to be discarded. Synchronous flush causes the handler to be called immediately when changes happen, solving the problem. See: https://github.com/vuejs/core/pull/7181 See: https://github.com/vuejs/docs/commit/80e2128d52603856a26a8bb7258606cfe80561e9 Fixes: a7dea2f70f2beba781068a7ff7d8a2a9ef8a9478 Fixes: #413

novenary added 1 commit 2024-09-16 19:54:57 +00:00

post_status_form: enable sync flush for watcher

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

13383982bc

This fixes drafts not clearing after posting a reply.

Vue 3.3.11 changed watchers to stop firing after component unmount.
After posting a reply, the post form is removed, now causing the queued
event to be discarded.
Synchronous flush causes the handler to be called immediately when
changes happen, solving the problem.

See: https://github.com/vuejs/core/pull/7181
See: 80e2128d52
Fixes: a7dea2f70f
Fixes: #413

Oneric commented

2024-10-14 21:05:05 +00:00

Member

Can confirm the issue and that this fix works.

Vue doc’s warning about perf implications warrants some attention though. Iirc you already tested individual keystrokes never got batched to begin with off-site, but how does flush: "sync" affect performance of pasted text compared to before the dep upgrade? Is there still only one update for the watcher to process, did it already trigger one update per character before, or does the event count explode with this? If all is fine, ideally document the findings in the commit message

Can confirm the issue and that this fix works. Vue doc’s warning about perf implications warrants some attention though. Iirc you already tested individual keystrokes never got batched to begin with off-site, but how does `flush: "sync"` affect performance of pasted text compared to before the dep upgrade? Is there still only one update for the watcher to process, did it already trigger one update per character before, or does the event count explode with this? If all is fine, ideally document the findings in the commit message

novenary commented

2024-10-14 21:16:24 +00:00

Author

First-time contributor

As far as I can tell, pasting is atomic (produces a single event) which makes intuitive sense to me.

novenary force-pushed sticky-drafts from 13383982bc to ef242a1ddd

2024-10-14 21:18:38 +00:00

Compare

novenary commented

2024-10-14 21:20:06 +00:00

Author

First-time contributor