Add toggle to hide posts mentioning blocked users #78

Ghost · 2022-07-29T18:35:58Z

Ghost commented

2022-07-29 18:35:58 +00:00

First-time contributor

      // XXX: doesn't work on domain blocks, because users from blocked domains
      // don't appear in `attentions' and therefore cannot be filtered.

even when not hidden, this tags those posts as filtered, like wordfiltered or muted user posts.

``` // XXX: doesn't work on domain blocks, because users from blocked domains // don't appear in `attentions' and therefore cannot be filtered. ``` even when not hidden, this tags those posts as filtered, like wordfiltered or muted user posts.

floatingghost commented

2022-07-29 18:48:22 +00:00

pretty poggers, that was quick

you've got a conflict in i18n stuff - and if i could be a bother ,the i18n key is a little ambiguous - maybe hideThreadWithBlockedUsers would be more descriptive

pretty poggers, that was quick you've got a conflict in i18n stuff - and if i could be a bother ,the i18n key is a little ambiguous - maybe `hideThreadWithBlockedUsers` would be more descriptive

Ghost commented

2022-07-29 21:03:02 +00:00

First-time contributor

that key is ambiguous, yeah, i think so too, but it's in line with other keys, like

        "hide_muted_posts": "Hide posts of muted users",

this is a REALLY bad key name but it is a precedent

that key is ambiguous, yeah, i think so too, but it's in line with other keys, like ```js "hide_muted_posts": "Hide posts of muted users", ``` this is a REALLY bad key name but it is a precedent

floatingghost commented

2022-07-29 23:15:25 +00:00

we have total control of this now, we can fix bad precedent :smug:

Ghost force-pushed hide-blocked-threads from 38cea74a0a to 669c583f37

2022-07-30 13:10:14 +00:00

Compare

Ghost commented

2022-07-30 13:10:32 +00:00

First-time contributor

yeah that's fair

floatingghost reviewed 2022-07-30 18:27:49 +00:00

floatingghost left a comment

just noticed one additional little thing, the rest looks good

src/components/status/status.js

					
				@ -264,0 +267,4 @@

				      let mentions = false

				      // find if user in mentions list is blocked

				      this.status.attentions.forEach((attn) => {

floatingghost commented

2022-07-30 18:27:18 +00:00

whilst this works, you could also do

return this.status.find((attn) => {
  if (attn.id === this.currentUser.id) return false;
  const relationship = this.$store.getters.relationship(attn.id)
  if (relationship.blocking) {
    return true;
  }
  return false;
}) !== undefined;

which avoids the mutating boolean thing you've got going on there

whilst this works, you could also do ```js return this.status.find((attn) => { if (attn.id === this.currentUser.id) return false; const relationship = this.$store.getters.relationship(attn.id) if (relationship.blocking) { return true; } return false; }) !== undefined; ``` which avoids the mutating boolean thing you've got going on there

Ghost commented

2022-07-30 20:05:07 +00:00

First-time contributor

this is clever but i think it's less immediately readable this way