AkkomaGang/akkoma-fe

Fork 70

WIP: Use raw status text instead of html encoded text #88

Closed

Ghost wants to merge 1 commit from (deleted):status-text into develop

Ghost commented

2022-07-31 19:42:21 +00:00

First-time contributor

do not merge
holy shit for the love of god do not merge

i wanna see just how much stuff this breaks, and if this could be deemed safe enough to use in production or if i should find a different solution for the mfm bug

characters like < and > are html-encoded in statuses meaning it's impossible to use <center> and <small> tags, as well as > quotes.

i could fix this in marked-mfm and just make it accept <
i probably should do that, actually

i'm just not smart enough to decide if this is a remotely good solution or not and i need feedback

**do not merge holy shit for the love of god do not merge** i wanna see just how much stuff this breaks, and if this could be deemed safe enough to use in production or if i should find a different solution for the mfm bug characters like `<` and `>` are html-encoded in statuses meaning it's impossible to use `<center>` and `<small>` tags, as well as `> quotes`. i could fix this in marked-mfm and just make it accept `<` i probably should do that, actually i'm just not smart enough to decide if this is a remotely good solution or not and i need feedback

Ghost added 1 commit 2022-07-31 19:42:22 +00:00

Use raw status text instead of html encoded text

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

cf72636562

floatingghost commented

2022-07-31 23:00:56 +00:00

Owner

these are indeed escaped by the backend

what we could do is allow it in the scrubber -> https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/priv/scrubbers/default.ex

which should pass <center> and <small> as expected

these are indeed escaped by the backend what we could do is allow it in the scrubber -> https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/priv/scrubbers/default.ex which should pass `<center>` and `<small>` as expected

Ghost commented

2022-07-31 23:02:14 +00:00

Author

First-time contributor

wouldn't that make them render as center and small in plaintext mode, too?

Ghost commented

2022-07-31 23:02:57 +00:00

Author

First-time contributor

(though actually that's a downside of this method as well i should just do the < thing)

(though actually that's a downside of this method as well i should just do the `<` thing)

floatingghost commented

2022-07-31 23:05:45 +00:00

Owner

nope, plaintext doesn't get passed through the same scrubber

works though so there's that

nope, plaintext doesn't get passed through the same scrubber ![image](/attachments/64f992a2-d7d4-4627-a446-440d7bf6e315) works though so there's that

image.png

38 KiB

Ghost commented

2022-07-31 23:07:02 +00:00

Author

First-time contributor

oh cool
and what about quotes?

> stuff

(also center is still broken you might notice that markdown formatting does not work inside a center tag, i fix that in a future marked-mfm version)

oh cool and what about quotes? ``` > stuff ``` (also center is still broken you might notice that markdown formatting does not work inside a center tag, i fix that in a future marked-mfm version)

floatingghost commented

2022-07-31 23:07:23 +00:00

Owner

ah it doesn't work inbound though

ok hm

ah it doesn't work inbound though ok hm

floatingghost commented

2022-07-31 23:15:12 +00:00

Owner

ok i found something that does work, one sec

ok i found something that _does_ work, one sec

floatingghost commented