AkkomaGang/akkoma
AkkomaGang/akkoma
15
65
Fork 92
Code Issues 177 Pull requests 24 Projects 2 Releases 14 Packages Wiki Activity

Remove unnecessary KillMode=process #359

Merged
floatingghost merged 1 commit from :remove-unnecessary-killmode into develop 2022-12-10 00:24:28 +00:00
Conversation 2 Commits 1 Files changed 1 -1
Ghost commented 2022-12-10 00:16:45 +00:00
First-time contributor
Copy link

It's unclear why this is the default as this is highly not recommended.
KillMode=process ends up leaving leftover orphaned processes that
escape resource management and process lifecycles, wasting resources
on servers.

The git blame for this seems to be a 5 year old Pleroma relic with
no documentation or reasoning for this that I could find online.

I have been using this with zero problems on my own servers.

systemd's default is control-group.

See https://www.freedesktop.org/software/systemd/man/systemd.kill.html

Signed-off-by: r3g_5z june@girlboss.ceo

It's unclear why this is the default as this is highly not recommended. KillMode=process ends up leaving leftover orphaned processes that escape resource management and process lifecycles, wasting resources on servers. The git blame for this seems to be a 5 year old Pleroma relic with no documentation or reasoning for this that I could find online. I have been using this with zero problems on my own servers. systemd's default is control-group. See https://www.freedesktop.org/software/systemd/man/systemd.kill.html Signed-off-by: r3g_5z <june@girlboss.ceo>
Ghost added 1 commit 2022-12-10 00:16:46 +00:00
Remove unnecessary KillMode=process
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
Details
90fce918b2 
It's unclear why this is the default as this is highly not recommended.
KillMode=process ends up leaving leftover orphaned processes that
escape resource management and process lifecycles, wasting resources
on servers.

Signed-off-by: r3g_5z <june@girlboss.ceo>
floatingghost commented 2022-12-10 00:24:09 +00:00
Owner
Copy link

!!! is THIS why my systemd keeps complaining about processes being left over????

i always wondered why that happened

thanks a lot!

!!! is _THIS_ why my systemd keeps complaining about processes being left over???? i always wondered why that happened thanks a lot!
floatingghost merged commit 59fde45b36 into develop 2022-12-10 00:24:28 +00:00
floatingghost deleted branch remove-unnecessary-killmode 2022-12-10 00:24:28 +00:00
Ghost commented 2022-12-10 00:25:39 +00:00
Author
First-time contributor
Copy link

Yep, this is exactly why systemd is telling you there are leftover processes.

Yep, this is exactly why systemd is telling you there are leftover processes.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#359
No description provided.
Delete branch ":remove-unnecessary-killmode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?