AkkomaGang/akkoma
AkkomaGang
/
akkoma
12
63
Fork 83
Code Issues 170 Pull Requests 17 Packages Projects 2 Releases 12 Wiki Activity

fix: Give error message to users when address has already been validated #435

Merged
floatingghost merged 1 commits from cheerfulstoic/akkoma:develop into develop 2023-01-15 18:06:13 +00:00
Conversation 1 Commits 1 Files Changed 2 +34 -9
cheerfulstoic commented 2023-01-12 21:09:26 +00:00
Contributor
Copy Link

Plus other errors.

I noticed this error originally when I signed up on genserver.social and hit the link a second time. I could imagine this might be confusing to somebody if the link opened in the same tab the second time or they just got confused up opening tabs/windows.

It made sense to my to change the 500s to 400s because 400 generally means there was something wrong with the request made and 500 usually means that there was an unexpected / unhandled error. Happy to talk that through, though.

Plus other errors. I noticed this error originally when I signed up on genserver.social and hit the link a second time. I could imagine this might be confusing to somebody if the link opened in the same tab the second time or they just got confused up opening tabs/windows. It made sense to my to change the 500s to 400s because 400 generally means there was something wrong with the request made and 500 usually means that there was an unexpected / unhandled error. Happy to talk that through, though.
cheerfulstoic added 1 commit 2023-01-12 21:09:27 +00:00
ci/woodpecker/pr/woodpecker Pipeline failed Details
7ca9ce9d67 fix: Give error message to users when address has already been validated 
Plus other errors.
floatingghost commented 2023-01-15 18:05:39 +00:00
Owner
Copy Link

(lint thing is my fault, apologies)

this looks good, and makes sense

thanks a lot!

(lint thing is my fault, apologies) this looks good, and makes sense thanks a lot!
🎉 1
floatingghost merged commit 975bc6d7e8 into develop 2023-01-15 18:06:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No Label
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#435
No description provided.
Delete Branch "cheerfulstoic/akkoma:develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?