[bug] Emoji reactions from Misskey/Foundkey #499

Closed
opened 2023-03-10 16:48:12 +00:00 by Johann150 · 2 comments

What were you trying to do?

Send an emoji reaction from Foundkey to Akkoma.

What did you expect to happen?

Akkoma receives the emoji reaction and reads the content field of the Like activity. (Note: The content attribute is defined by ActivityPub.)

What actually happened?

Akkoma only checks the _misskey_reaction attribute (defined by Misskey), even though the content attribute (defined by ActivityPub) has been provided by Misskey for a long time (since 2020-02-06) and is still provided. Since the content attribute is defined by ActivityPub it should IMHO be preferred.

See also FoundKeyGang/FoundKey#354

Severity

I cannot use it as easily as I'd like

Have you searched for this issue?

  • I have double-checked and have not found this issue mentioned anywhere.
### What were you trying to do? Send an emoji reaction from Foundkey to Akkoma. ### What did you expect to happen? Akkoma receives the emoji reaction and reads the `content` field of the `Like` activity. (Note: The `content` attribute is defined by ActivityPub.) ### What actually happened? Akkoma only checks the `_misskey_reaction` attribute (defined by Misskey), even though the `content` attribute (defined by ActivityPub) has been provided by Misskey [for a long time (since 2020-02-06)](https://github.com/misskey-dev/misskey/commit/988ac80087a116173ab36043a7a9dd2228d2986c#diff-12e8576204846b63bad4472ff3737065ab6985294a984a51bb320628161c2cd2) and [is still provided](https://github.com/misskey-dev/misskey/blob/65b1524f928d546ecb885be98655f7eb39c9cba2/packages/backend/src/core/activitypub/ApRendererService.ts#L266). Since the `content` attribute is defined by ActivityPub it should IMHO be preferred. See also https://akkoma.dev/FoundKeyGang/FoundKey/issues/354 ### Severity I cannot use it as easily as I'd like ### Have you searched for this issue? - [x] I have double-checked and have not found this issue mentioned anywhere.
Johann150 added the
bug
label 2023-03-10 16:48:12 +00:00

ah misskey_reaction was finally purged huh

yea i guess we can remove matching there

hooray

ah misskey_reaction was finally purged huh yea i guess we can remove matching there hooray

fixed via e124a109c1

fixed via https://akkoma.dev/AkkomaGang/akkoma/commit/e124a109c1897529b4b9eae563f550b9fb5dfb50
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#499
No description provided.