Custom emote reacts from FoundKey turn into Akkoma faves #354

New issue

Closed

opened 2023-03-10 14:32:58 +00:00 by iqturaweodponggas · 2 comments

iqturaweodponggas commented

2023-03-10 14:32:58 +00:00

In 68bc2e314b, the _misskey_reaction property was removed from outgoing emote reacts.

This breaks federation of custom emote reacts with Akkoma. Akkoma relies on that property being there to translate it. https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/lib/pleroma/web/activity_pub/transmogrifier.ex#L422

I don't know (and honestly have no business telling you) whether this means 68bc2e314b should be reverted or Akkoma adjusted (or both in case something other than Akkoma relied on this behavior).

In 68bc2e314b, the `_misskey_reaction` property was removed from outgoing emote reacts. This breaks federation of custom emote reacts with Akkoma. Akkoma relies on that property being there to translate it. https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/lib/pleroma/web/activity_pub/transmogrifier.ex#L422 I don't know (and honestly have no business telling you) whether this means 68bc2e314b should be reverted or Akkoma adjusted (or both in case something other than Akkoma relied on this behavior).

Johann150 commented

2023-03-10 16:47:10 +00:00

Owner

I think Akkoma should be adjusted to use the content attribute, which has been provided by Misskey for a long time. The _misskey_reaction attribute has been removed in favour of the content attribute since the latter is defined by ActivityPub while the former is not.

I think Akkoma should be adjusted to use the `content` attribute, which has been provided by Misskey for a long time. The `_misskey_reaction` attribute has been removed in favour of the `content` attribute since the latter is defined by ActivityPub while the former is not.