[bug] twitter:description shows bio instead of post in static-fe #644

New issue

Closed

opened 2023-09-29 16:40:05 +00:00 by twpol · 0 comments

twpol commented

2023-09-29 16:40:05 +00:00

Your setup

No response

Extra details

No response

Version

3.10.3-197-g98f0820c-develop

PostgreSQL version

No response

What were you trying to do?

Pasting a post from https://akko.wtf/ into Telegram.

What did you expect to happen?

Telegram expanded the post to show the textual content.

What actually happened?

Telegram expanded the post to show the user's bio.

More Information

I am not a user on https://akko.wtf/ nor do I even use this software; however, I am reporting this bug in the hope that the issue can be fixed for those that do.

It looks to me, and I could be completely wrong, that #365 / #373 swapped a problem with og:description for a problem with twitter:description since they define their build_tags for posts differently.

OG: def build_tags(%{object: object, url: url, user: user}) do at

   def build_tags(%{
         object: object,
         url: url,
         user: user
       }) do

Twitter: def build_tags(%{activity_id: id, object: object, user: user}) do at

def build_tags(%{activity_id: id, object: object, user: user}) do

I think these need to both take the same parameter structure for the call on

meta = Metadata.build_tags(%{url: activity.data["id"], object: activity.object, user: user})

to work.

Severity

I can manage

Have you searched for this issue?

I have double-checked and have not found this issue mentioned anywhere.

### Your setup _No response_ ### Extra details _No response_ ### Version 3.10.3-197-g98f0820c-develop ### PostgreSQL version _No response_ ### What were you trying to do? Pasting a post from https://akko.wtf/ into Telegram. ### What did you expect to happen? Telegram expanded the post to show the textual content. ### What actually happened? Telegram expanded the post to show the user's bio. ### More Information I am not a user on https://akko.wtf/ nor do I even use this software; however, I am reporting this bug in the hope that the issue can be fixed for those that do. It looks to me, and I could be completely wrong, that #365 / #373 swapped a problem with `og:description` for a problem with `twitter:description` since they define their `build_tags` for posts differently. OG: `def build_tags(%{object: object, url: url, user: user}) do` at https://akkoma.dev/AkkomaGang/akkoma/src/commit/d1af78aba11a20da17bbe2a7c0bf303bf30f6323/lib/pleroma/web/metadata/providers/open_graph.ex#L16-L20 Twitter: `def build_tags(%{activity_id: id, object: object, user: user}) do` at https://akkoma.dev/AkkomaGang/akkoma/src/commit/d1af78aba11a20da17bbe2a7c0bf303bf30f6323/lib/pleroma/web/metadata/providers/twitter_card.ex#L19 I think these need to both take the same parameter structure for the call on https://akkoma.dev/AkkomaGang/akkoma/src/commit/1d884fd9143dc165d745bf1b5e86bcc65332d6b9/lib/pleroma/web/static_fe/static_fe_controller.ex#L28 to work. ### Severity I can manage ### Have you searched for this issue? - [x] I have double-checked and have not found this issue mentioned anywhere.