AkkomaGang/akkoma
AkkomaGang/akkoma
15
66
Fork 94
Code Issues 182 Pull requests 28 Projects 2 Releases 14 Packages Wiki Activity

Purge leftovers from chats #684

Merged
floatingghost merged 2 commits from Oneric/akkoma:cosmetic-purge-chat into develop 2024-02-13 09:13:38 +00:00
Conversation 1 Commits 2 Files changed 3 +50 -7
Oneric commented 2024-02-11 04:19:21 +00:00
Member
Copy link

All of the functionality was already gutted in 0f132b802d but some (now unused) config settings and the two tables were left. (There already are no more references to disableChat or :shout in the config cheatsheet)

I confirmed the migration successfully applies both ways

This cleanup is mostly cosmetic — unless someone migrated from Pleroma and still has data stored in the tables. In this case some space will be reclaimed. I guess in theory this may be data loss if later migrating back to Pleroma, but if really desired a backup can be made before

EDIT: if this gets merged before #674 , the migration id in #674 will need to be bumped to avoid confusing Ecto

For reference these are the table schema before (and also after reverting) the migration

akkoma=> \d+ chat_message_references
                                               Table "public.chat_message_references"
   Column    |              Type              | Collation | Nullable | Default | Storage | Compression | Stats target | Description 
-------------+--------------------------------+-----------+----------+---------+---------+-------------+--------------+-------------
 id          | uuid                           |           | not null |         | plain   |             |              | 
 chat_id     | uuid                           |           | not null |         | plain   |             |              | 
 object_id   | bigint                         |           | not null |         | plain   |             |              | 
 inserted_at | timestamp(0) without time zone |           | not null |         | plain   |             |              | 
 updated_at  | timestamp(0) without time zone |           | not null |         | plain   |             |              | 
 unread      | boolean                        |           | not null | true    | plain   |             |              | 
Indexes:
    "chat_message_references_pkey" PRIMARY KEY, btree (id)
    "chat_message_references_chat_id_id_desc_index" btree (chat_id, id DESC)
    "chat_message_references_object_id_chat_id_index" UNIQUE, btree (object_id, chat_id)
    "unread_messages_count_index" btree (chat_id) WHERE unread = true
Foreign-key constraints:
    "chat_message_references_chat_id_fkey" FOREIGN KEY (chat_id) REFERENCES chats(id) ON DELETE CASCADE
    "chat_message_references_object_id_fkey" FOREIGN KEY (object_id) REFERENCES objects(id) ON DELETE CASCADE
Access method: heap

akkoma=> \d+ chats
                                                        Table "public.chats"
   Column    |              Type              | Collation | Nullable | Default | Storage  | Compression | Stats target | Description 
-------------+--------------------------------+-----------+----------+---------+----------+-------------+--------------+-------------
 id          | uuid                           |           | not null |         | plain    |             |              | 
 user_id     | uuid                           |           |          |         | plain    |             |              | 
 recipient   | character varying(255)         |           |          |         | extended |             |              | 
 inserted_at | timestamp(0) without time zone |           | not null |         | plain    |             |              | 
 updated_at  | timestamp(0) without time zone |           | not null |         | plain    |             |              | 
Indexes:
    "chats_pkey" PRIMARY KEY, btree (id)
    "chats_user_id_recipient_index" UNIQUE, btree (user_id, recipient)
Foreign-key constraints:
    "chats_recipient_fkey" FOREIGN KEY (recipient) REFERENCES users(ap_id) ON DELETE CASCADE
    "chats_user_id_fkey" FOREIGN KEY (user_id) REFERENCES users(id) ON DELETE CASCADE
Referenced by:
    TABLE "chat_message_references" CONSTRAINT "chat_message_references_chat_id_fkey" FOREIGN KEY (chat_id) REFERENCES chats(id) ON DELETE CASCADE
Access method: heap
All of the functionality was already gutted in 0f132b802dde7f217ecb07767e0d34e3edb517b7 but some (now unused) config settings and the two tables were left. (There already are no more references to `disableChat` or `:shout` in the config cheatsheet) I confirmed the migration successfully applies both ways This cleanup is mostly cosmetic — unless someone migrated from Pleroma and still has data stored in the tables. In this case some space will be reclaimed. I guess in theory this may be data loss if later migrating back to Pleroma, but if really desired a backup can be made before **EDIT:** if this gets merged before #674 , the migration id in #674 will need to be bumped to avoid confusing Ecto -------- For reference these are the table schema before (and also after reverting) the migration ``` akkoma=> \d+ chat_message_references Table "public.chat_message_references" Column | Type | Collation | Nullable | Default | Storage | Compression | Stats target | Description -------------+--------------------------------+-----------+----------+---------+---------+-------------+--------------+------------- id | uuid | | not null | | plain | | | chat_id | uuid | | not null | | plain | | | object_id | bigint | | not null | | plain | | | inserted_at | timestamp(0) without time zone | | not null | | plain | | | updated_at | timestamp(0) without time zone | | not null | | plain | | | unread | boolean | | not null | true | plain | | | Indexes: "chat_message_references_pkey" PRIMARY KEY, btree (id) "chat_message_references_chat_id_id_desc_index" btree (chat_id, id DESC) "chat_message_references_object_id_chat_id_index" UNIQUE, btree (object_id, chat_id) "unread_messages_count_index" btree (chat_id) WHERE unread = true Foreign-key constraints: "chat_message_references_chat_id_fkey" FOREIGN KEY (chat_id) REFERENCES chats(id) ON DELETE CASCADE "chat_message_references_object_id_fkey" FOREIGN KEY (object_id) REFERENCES objects(id) ON DELETE CASCADE Access method: heap akkoma=> \d+ chats Table "public.chats" Column | Type | Collation | Nullable | Default | Storage | Compression | Stats target | Description -------------+--------------------------------+-----------+----------+---------+----------+-------------+--------------+------------- id | uuid | | not null | | plain | | | user_id | uuid | | | | plain | | | recipient | character varying(255) | | | | extended | | | inserted_at | timestamp(0) without time zone | | not null | | plain | | | updated_at | timestamp(0) without time zone | | not null | | plain | | | Indexes: "chats_pkey" PRIMARY KEY, btree (id) "chats_user_id_recipient_index" UNIQUE, btree (user_id, recipient) Foreign-key constraints: "chats_recipient_fkey" FOREIGN KEY (recipient) REFERENCES users(ap_id) ON DELETE CASCADE "chats_user_id_fkey" FOREIGN KEY (user_id) REFERENCES users(id) ON DELETE CASCADE Referenced by: TABLE "chat_message_references" CONSTRAINT "chat_message_references_chat_id_fkey" FOREIGN KEY (chat_id) REFERENCES chats(id) ON DELETE CASCADE Access method: heap ```
Oneric added 2 commits 2024-02-11 04:19:21 +00:00 
Their functions were purged in 0f132b802d
Drop Chat tables
All checks were successful
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/build-amd64 Pipeline was successful
Details
ci/woodpecker/pr/build-arm64 Pipeline was successful
Details
ci/woodpecker/pr/docs Pipeline was successful
Details
8cf183cb42 
Chats were removed in 0f132b802d
floatingghost commented 2024-02-13 09:13:35 +00:00
Owner
Copy link

so long chats o7

thanks!

so long chats o7 thanks!
floatingghost merged commit 6fde75e1f0 into develop 2024-02-13 09:13:38 +00:00
Oneric deleted branch cosmetic-purge-chat 2024-02-13 14:32:06 +00:00
ilja referenced this pull request from a commit 2024-02-19 07:53:47 +00:00
Changes are not non-destructive any more
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#684
No description provided.
Delete branch "Oneric/akkoma:cosmetic-purge-chat"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?