AkkomaGang/akkoma
AkkomaGang/akkoma
15
65
Fork 92
Code Issues 177 Pull requests 24 Projects 2 Releases 14 Packages Wiki Activity

EmojiReactValidator: fix emoji qualification #111

Closed
norm wants to merge 1 commit from norm/akkoma:fix/emoji-qualification into develop
pull from: norm/akkoma:fix/emoji-qualification
merge into: AkkomaGang:develop
Conversation 2 Commits 1 Files changed 3 +75
norm commented 2022-07-24 19:27:55 +00:00
Contributor
Copy link

From upstream MR: https://git.pleroma.social/pleroma/pleroma/-/merge_requests/3708

Tries fully-qualifying emoji when receiving them, by adding the emoji
variation sequence to the received reaction emoji.

This issue arises when other instance software, such as Misskey, tries
reacting with emoji that have unqualified or minimally qualified
variants, like a red heart. Pleroma only accepts fully qualified emoji
in emoji reactions, and refused those emoji. Now, Pleroma will attempt
to properly qualify them first, and reject them if checks still fail.

This commit contains changes to tests proposed by lanodan.

From upstream MR: https://git.pleroma.social/pleroma/pleroma/-/merge_requests/3708 > Tries fully-qualifying emoji when receiving them, by adding the emoji > variation sequence to the received reaction emoji. > > This issue arises when other instance software, such as Misskey, tries > reacting with emoji that have unqualified or minimally qualified > variants, like a red heart. Pleroma only accepts fully qualified emoji > in emoji reactions, and refused those emoji. Now, Pleroma will attempt > to properly qualify them first, and reject them if checks still fail. > > This commit contains changes to tests proposed by lanodan.
norm added 1 commit 2022-07-24 19:27:56 +00:00
EmojiReactValidator: fix emoji qualification
Some checks failed
ci/woodpecker/pr/release Pipeline was successful
Details
ci/woodpecker/pr/docs Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline failed
Details
0906de9fda 
Tries fully-qualifying emoji when receiving them, by adding the emoji
variation sequence to the received reaction emoji.

This issue arises when other instance software, such as Misskey, tries
reacting with emoji that have unqualified or minimally qualified
variants, like a red heart. Pleroma only accepts fully qualified emoji
in emoji reactions, and refused those emoji. Now, Pleroma will attempt
to properly qualify them first, and reject them if checks still fail.

This commit contains changes to tests proposed by lanodan.

Co-authored-by: Haelwenn <contact+git.pleroma.social@hacktivis.me>
floatingghost commented 2022-07-25 01:38:27 +00:00
Owner
Copy link

one test failure, likely from changes colliding with our own - you can likely just replace the emoji and it'll be fine(tm)

one test failure, likely from changes colliding with our own - you can likely just replace the emoji and it'll be fine(tm)
norm commented 2022-07-25 02:28:11 +00:00
Author
Contributor
Copy link

On second thought, this probably isn't necessary since ad0b8c095c added in the "unqualified" emoji as valid emoji. May just close this PR then.

On second thought, this probably isn't necessary since ad0b8c095c added in the "unqualified" emoji as valid emoji. May just close this PR then.
norm closed this pull request 2022-07-25 02:28:11 +00:00
Some checks failed
ci/woodpecker/pr/release Pipeline was successful
Details
ci/woodpecker/pr/docs Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline failed
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#111
No description provided.
Delete branch "norm/akkoma:fix/emoji-qualification"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?