AkkomaGang/akkoma
AkkomaGang/akkoma
17
68
Fork 110
Code Issues 145 Pull requests 16 Projects 2 Releases 21 Packages Wiki Activity

Fix emoji qualification #124

Merged
floatingghost merged 4 commits from emoji-qualification into develop 2022-07-28 12:02:36 +00:00
Conversation 0 Commits 4 Files changed 7 +120 -4
floatingghost commented 2022-07-28 12:02:31 +00:00
Owner
Copy link

thanks heleeeeene

thanks heleeeeene
Tries fully-qualifying emoji when receiving them, by adding the emoji
variation sequence to the received reaction emoji.

This issue arises when other instance software, such as Misskey, tries
reacting with emoji that have unqualified or minimally qualified
variants, like a red heart. Pleroma only accepts fully qualified emoji
in emoji reactions, and refused those emoji. Now, Pleroma will attempt
to properly qualify them first, and reject them if checks still fail.

This commit contains changes to tests proposed by lanodan.

Co-authored-by: Haelwenn <contact+git.pleroma.social@hacktivis.me>
Emoji: implement full-qualifier using combinations

See merge request pleroma/pleroma!3709
adapt emoji qualification for customs
Some checks are pending
ci/woodpecker/push/woodpecker Pipeline is pending
Details
3ba6667654
fix redirects and search formatting
Some checks are pending
ci/woodpecker/push/woodpecker Pipeline is pending
Details
ci/woodpecker/pr/woodpecker Pipeline is pending
Details
18cad411f7
floatingghost deleted branch emoji-qualification 2022-07-28 12:02:36 +00:00
floatingghost referenced this pull request from a commit 2022-07-28 12:02:36 +00:00
Fix emoji qualification (#124)
rat referenced this pull request from a commit 2024-02-25 20:33:28 +00:00
Fix emoji qualification (#124)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
cannot reproduce

   
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs change/feedback

Issue or PR is stalled on response from the author or a third party

  
needs docs

   
needs tests

   
not a bug

   
not our bug

Bug in a dependency of ours (meaning we can't just fix it), or in another AP implementation or client interfacing with Akkoma (which needs to be fixed on their end)

  
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
cannot reproduce
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs change/feedback
needs docs
needs tests
not a bug
not our bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AkkomaGang/akkoma!124
No description provided.