fix_flaky_transfer_task_test.exs #237

Merged
floatingghost merged 2 commits from ilja/akkoma:fix_flaky_transfer_task_test.exs into develop 1 month ago
ilja commented 2 months ago

There were async calls happening, so they weren't always finished when assert happened.

I also fixed some bugs in the erratic tests that were introduced when removing :shout.:shout is a key where restart is needed, and was changed in the test to use :rate_limit (which also requires a restart). But there was a bug in the syntax that didn't get caught because the test was tagged as erratic and therefor didn't fail. Here I fixed it.

During compilation, we had a warning :logger is used by the current application but the current application does not depend on :logger which is now fixed as well (see commit message for complete stacktrace).

There were async calls happening, so they weren't always finished when assert happened. I also fixed some bugs in the erratic tests that were introduced when removing :shout.:shout is a key where restart is needed, and was changed in the test to use :rate_limit (which also requires a restart). But there was a bug in the syntax that didn't get caught because the test was tagged as erratic and therefor didn't fail. Here I fixed it. During compilation, we had a warning `:logger is used by the current application but the current application does not depend on :logger` which is now fixed as well (see commit message for complete stacktrace).
ilja added 2 commits 2 months ago
85b29a7ed2
Fix warnings ":logger is used by the current application but the current application does not depend on :logger"
ci/woodpecker/pr/woodpecker Pipeline is pending Details
648bb0e5d3
Fix flaky/erratic tests in Pleroma.Config.TransferTaskTest
Owner

oh so that is where the logger complaining was coming from

everything else seems sensible

oh so _that_ is where the logger complaining was coming from everything else seems sensible
floatingghost merged commit be5044f785 into develop 1 month ago
floatingghost deleted branch fix_flaky_transfer_task_test.exs 1 month ago
ci/woodpecker/pr/woodpecker Pipeline is pending
The pull request has been merged as be5044f785.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#237
Loading…
There is no content yet.