Labels Milestones

fix_flaky_transfer_task_test.exs #237

Merged

floatingghost merged 2 commits from ilja/akkoma:fix_flaky_transfer_task_test.exs into develop 3 months ago

Conversation 1 Commits 2 Files Changed 3

ilja commented 3 months ago

There were async calls happening, so they weren't always finished when assert happened.

I also fixed some bugs in the erratic tests that were introduced when removing :shout.:shout is a key where restart is needed, and was changed in the test to use :rate_limit (which also requires a restart). But there was a bug in the syntax that didn't get caught because the test was tagged as erratic and therefor didn't fail. Here I fixed it.

During compilation, we had a warning :logger is used by the current application but the current application does not depend on :logger which is now fixed as well (see commit message for complete stacktrace).

There were async calls happening, so they weren't always finished when assert happened. I also fixed some bugs in the erratic tests that were introduced when removing :shout.:shout is a key where restart is needed, and was changed in the test to use :rate_limit (which also requires a restart). But there was a bug in the syntax that didn't get caught because the test was tagged as erratic and therefor didn't fail. Here I fixed it. During compilation, we had a warning `:logger is used by the current application but the current application does not depend on :logger` which is now fixed as well (see commit message for complete stacktrace).

ilja added 2 commits 3 months ago

85b29a7ed2 Fix warnings ":logger is used by the current application but the current application does not depend on :logger" ...

During compilation, we had the following warning which is now fixed

```
==> restarter
Compiling 1 file (.ex)
warning: Logger.__do_log__/4 defined in application :logger is used by the current application but the current application does not depend on :logger. To fix this, you must do one of:

  1. If :logger is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :logger is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :logger, you may optionally skip this warning by adding [xref: [exclude: [Logger]]] to your "def project" in mix.exs

Invalid call found at 2 locations:
  lib/pleroma.ex:65: Restarter.Pleroma.handle_cast/2
  lib/pleroma.ex:78: Restarter.Pleroma.handle_cast/2

warning: Logger.__should_log__/2 defined in application :logger is used by the current application but the current application does not depend on :logger. To fix this, you must do one of:

  1. If :logger is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :logger is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :logger, you may optionally skip this warning by adding [xref: [exclude: [Logger]]] to your "def project" in mix.exs

Invalid call found at 2 locations:
  lib/pleroma.ex:65: Restarter.Pleroma.handle_cast/2
  lib/pleroma.ex:78: Restarter.Pleroma.handle_cast/2

warning: Logger.debug/1 defined in application :logger is used by the current application but the current application does not depend on :logger. To fix this, you must do one of:

  1. If :logger is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :logger is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :logger, you may optionally skip this warning by adding [xref: [exclude: [Logger]]] to your "def project" in mix.exs

Invalid call found at 2 locations:
  lib/pleroma.ex:65: Restarter.Pleroma.handle_cast/2
  lib/pleroma.ex:78: Restarter.Pleroma.handle_cast/2
```

648bb0e5d3 Fix flaky/erratic tests in Pleroma.Config.TransferTaskTest ...

There were async calls happening, so they weren't always finished when assert happened.

I also fixed some bugs in the erratic tests that were introduced when removing :shout.
:shout is a key where restart is needed, and was changed in the test to use :rate_limit
But there was a bug in the syntax that didn't get caught because the test was tagged as
erratic and therefor didn't fail. Here I fixed it.

floatingghost commented 3 months ago

Owner

oh so that is where the logger complaining was coming from

everything else seems sensible

oh so _that_ is where the logger complaining was coming from everything else seems sensible

floatingghost merged commit be5044f785 into develop 3 months ago

floatingghost deleted branch fix_flaky_transfer_task_test.exs 3 months ago

floatingghost referenced this issue from a commit 3 months ago

fix_flaky_transfer_task_test.exs (#237)

ci/woodpecker/pr/woodpecker Pipeline is pending

Details

The pull request has been merged as be5044f785.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

approved, awaiting change bug
Something is not working configuration
This requires config changes documentation
This is about human-readable docs duplicate
This issue or pull request already exists enhancement
New feature extremely low priority feature request
Something new? help wanted
Need some help invalid
Something is wrong mastodon_api needs docs needs tests not a bug planned pleroma_api privacy question
More information is needed static_fe triage wontfix
This won't be fixed

No Label approved, awaiting change bug configuration documentation duplicate enhancement extremely low priority feature request help wanted invalid mastodon_api needs docs needs tests not a bug planned pleroma_api privacy question static_fe triage wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#237

Write Preview

Loading…

Cancel

Save

There is no content yet.