fix flaky test_user_relationship_test.exs:81 #240

Merged
floatingghost merged 1 commit from ilja/akkoma:fix_flaky_test_user_relationship_test.exs_81 into develop 2022-11-01 14:44:23 +00:00
Contributor

The problem was double. On the one hand, the function didn't actually return what was in the DB.
On the other hand the test was flaky because it used NaiveDateTime.utc_now() so test could fail or pass depending on a difference of microseconds.

Both are fixed now.

The problem was double. On the one hand, the function didn't actually return what was in the DB. On the other hand the test was flaky because it used NaiveDateTime.utc_now() so test could fail or pass depending on a difference of microseconds. Both are fixed now.
ilja added 1 commit 2022-10-23 11:55:56 +00:00
fix flaky test_user_relationship_test.exs:81
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
3562eaeedc
The problem was double. On the one hand, the function didn't actually return what was in the DB.
On the other hand the test was flaky because it used NaiveDateTime.utc_now() so test could fail or pass depending on a difference of microseconds.

Both are fixed now.

yeah honestly not returning the db record sound about right for relationship stuff...

and hooray less system clock stuff

thanks!

yeah honestly not returning the db record sound about right for relationship stuff... and hooray less system clock stuff thanks!
floatingghost merged commit e44e147b54 into develop 2022-11-01 14:44:23 +00:00
floatingghost deleted branch fix_flaky_test_user_relationship_test.exs_81 2022-11-01 14:44:24 +00:00
Sign in to join this conversation.
No description provided.