Change follow_operation schema to use type BooleanLike

ave commented

2022-11-23 14:53:22 +00:00

Contributor

Changes follow_operation schema to use BooleanLike instead of :boolean so that strings like "0" and "1" (used by mastodon.py) can be accepted. Rest of file uses the same. For more info please see https://git.pleroma.social/pleroma/pleroma/-/issues/2999

(I'm also sending this here as I'm not hopeful about upstream not ignoring it)

Changes follow_operation schema to use BooleanLike instead of :boolean so that strings like "0" and "1" (used by mastodon.py) can be accepted. Rest of file uses the same. For more info please see https://git.pleroma.social/pleroma/pleroma/-/issues/2999 (I'm also sending this here as I'm not hopeful about upstream not ignoring it)

👍 1

floatingghost commented

2022-11-24 11:04:00 +00:00

Owner

this looks good! whilst honestly i prefer true/false semantically, we should absolutely match masto's behaviour here

i'll wait for CI to run, assuming all passes i'm happy to merge this

this looks good! whilst honestly i prefer `true/false` semantically, we should absolutely match masto's behaviour here i'll wait for CI to run, assuming all passes i'm happy to merge this

floatingghost commented

2022-11-24 11:04:38 +00:00

Owner

oh, but it would be great if you could add a little line in CHANGELOG mentioning it

ave commented

2022-11-24 11:17:22 +00:00

Author

Contributor

Updated changelog, used Changed (also the last release seems to have incorrectly called it Changes, so I corrected that too-- I hope that's okay ^^).

If you'd like me to move it to Fixed instead, I can also do that.

Updated changelog, used `Changed` (also the last release seems to have incorrectly called it `Changes`, so I corrected that too-- I hope that's okay ^^). If you'd like me to move it to `Fixed` instead, I can also do that.

ave force-pushed fix-follow-schema from becdd6ceae to 5bdc6290f4

2022-11-24 11:22:08 +00:00

Compare

floatingghost commented

2022-11-24 11:26:55 +00:00

Owner

wonderful, CI is all passing - thanks for fixing the typo as well

much appreciated!

wonderful, CI is all passing - thanks for fixing the typo as well much appreciated!

👍 1