AkkomaGang/akkoma
AkkomaGang/akkoma
15
65
Fork 92
Code Issues 176 Pull requests 24 Projects 2 Releases 14 Packages Wiki Activity

minor-changes #313

Merged
floatingghost merged 4 commits from :minor-changes into develop 2022-11-26 19:27:58 +00:00
Conversation 2 Commits 4 Files changed 5 +7 -6
Ghost commented 2022-11-26 05:27:01 +00:00
First-time contributor
Copy link

Only real change here is making MRF rejects log as debug instead of info (#234)

I don't know if it's the best way to do it, but it seems it's just MRF using this and almost always this is intended.

The rest are just minor docs changes and syncing the restricted nicknames stuff.

I compiled and ran my changes with Docker and they all work.

Only real change here is making MRF rejects log as debug instead of info (https://akkoma.dev/AkkomaGang/akkoma/issues/234) I don't know if it's the best way to do it, but it seems it's just MRF using this and almost always this is intended. The rest are just minor docs changes and syncing the restricted nicknames stuff. I compiled and ran my changes with Docker and they all work.
floatingghost reviewed 2022-11-26 18:15:11 +00:00
config/config.exs Outdated
@ -512,6 +512,7 @@ config :pleroma, Pleroma.User,
"~",
"about",
"activities",
"akkoma",
floatingghost commented 2022-11-26 18:15:11 +00:00
Owner
Copy link

we probably don't need to restrict this - this setting is only there to prevent path-matching issues - but i don't think anything except swagger is served at /akkoma/* (i run a user called akkoma and it seems fine anyhow)

we probably don't need to restrict this - this setting is only there to prevent path-matching issues - but i don't think anything except swagger is served at `/akkoma/*` (i run a user called akkoma and it seems fine anyhow)
Ghost commented 2022-11-26 19:00:25 +00:00
Author
First-time contributor
Copy link

I'll just drop that commit then. I wasn't aware there was an actual technical reason behind adding pleroma, so if akkoma is fine then this isn't needed.

I'll just drop that commit then. I wasn't aware there was an actual technical reason behind adding `pleroma`, so if `akkoma` is fine then this isn't needed.
floatingghost reviewed 2022-11-26 18:16:01 +00:00
floatingghost left a comment
Owner
Copy link

probably no need to restrict the nicks, but otherwise ok

will wait on the typo then this should be ok

probably no need to restrict the nicks, but otherwise ok will wait on the typo then this should be ok
docs/docs/installation/docker_en.md Outdated
@ -52,3 +52,3 @@
This will ask you a few questions - the defaults are fine for most things,
the database hostname is `db`, and you will want to set the ip to `0.0.0.0`.
the database hostname is `db`, the database passowrd is `akkoma`
floatingghost commented 2022-11-26 18:15:32 +00:00
Owner
Copy link

typo here, password

typo here, `password`
Ghost marked this conversation as resolved
Ghost force-pushed minor-changes from 7c9f4917ef to 580afed663 2022-11-26 18:59:19 +00:00 Compare
Ghost commented 2022-11-26 19:00:41 +00:00
Author
First-time contributor
Copy link

Modified commits as needed

Modified commits as needed
floatingghost commented 2022-11-26 19:27:54 +00:00
Owner
Copy link

thanks, that all looks ok

thanks, that all looks ok
floatingghost merged commit 565ead8397 into develop 2022-11-26 19:27:58 +00:00
floatingghost deleted branch minor-changes 2022-11-26 19:27:59 +00:00
floatingghost referenced this pull request from a commit 2022-11-26 19:27:59 +00:00
minor-changes (#313)
rat referenced this pull request from a commit 2024-02-25 20:33:30 +00:00
minor-changes (#313)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#313
No description provided.
Delete branch ":minor-changes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?