AkkomaGang/akkoma
AkkomaGang/akkoma
15
64
Fork 88
Code Issues 174 Pull requests 20 Projects 2 Releases 14 Packages Wiki Activity

Fix tagpolicy to also work with Update #354

Closed
ilja wants to merge 0 commits from ilja/akkoma:fix_tagpolicy_to_also_work_on_updates into develop
pull from: ilja/akkoma:fix_tagpolicy_to_also_work_on_updates
merge into: AkkomaGang:develop
Conversation 2 Commits - Files changed - +375 -29
ilja commented 2022-12-08 20:57:09 +00:00
Contributor
Copy link

Fixes #340

Objects who got updated would just pass the TagPolicy, undoing the moderation that was set in place for the Actor.
Now we check not only for Create activities, but also Update activities.

I checked which other MRF's checked explicitly on type Create using grep '"type" => "Create"' lib/pleroma/web/activity_pub/mrf/* and fixed those in a similar way.

The following from that list who have not been changed:

  • lib/pleroma/web/activity_pub/mrf/follow_bot_policy.ex
    • Not relevant for moderation
  • lib/pleroma/web/activity_pub/mrf/keyword_policy.ex
    • Already had a test for Update
  • lib/pleroma/web/activity_pub/mrf/object_age_policy.ex
    • In practice only relevant when fetching old objects (e.g. through Like or Announce). These are always wrapped in a Create.
  • lib/pleroma/web/activity_pub/mrf/reject_non_public.ex
    • We don't allow changing scope with Update, so probably not relevant here
Fixes https://akkoma.dev/AkkomaGang/akkoma/issues/340 Objects who got updated would just pass the TagPolicy, undoing the moderation that was set in place for the Actor. Now we check not only for Create activities, but also Update activities. I checked which other MRF's checked explicitly on type Create using `grep '"type" => "Create"' lib/pleroma/web/activity_pub/mrf/*` and fixed those in a similar way. The following from that list who have not been changed: * lib/pleroma/web/activity_pub/mrf/follow_bot_policy.ex * Not relevant for moderation * lib/pleroma/web/activity_pub/mrf/keyword_policy.ex * Already had a test for Update * lib/pleroma/web/activity_pub/mrf/object_age_policy.ex * In practice only relevant when fetching old objects (e.g. through Like or Announce). These are always wrapped in a Create. * lib/pleroma/web/activity_pub/mrf/reject_non_public.ex * We don't allow changing scope with Update, so probably not relevant here
ilja added 1 commit 2022-12-08 20:57:10 +00:00
Fix tagpolicy to also work with Update
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
Details
ce517ff4e5 
Objects who got updated would just pass the TagPolicy, undoing the moderation that was set in place for the Actor.
Now we check not only for Create activities, but also Update activities.
ilja added 1 commit 2022-12-08 22:23:01 +00:00
Fix MRF policies to also work with Update
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
Details
1f863f0a36 
Objects who got updated would just pass through several of the MRF policies, undoing moderation in some situations.
In the relevant cases we now check not only for Create activities, but also Update activities.

I checked which ones checked explicitly on type Create using `grep '"type" => "Create"' lib/pleroma/web/activity_pub/mrf/*`.

The following from that list have not been changed:
* lib/pleroma/web/activity_pub/mrf/follow_bot_policy.ex
    * Not relevant for moderation
* lib/pleroma/web/activity_pub/mrf/keyword_policy.ex
    * Already had a test for Update
* lib/pleroma/web/activity_pub/mrf/object_age_policy.ex
    * In practice only relevant when fetching old objects (e.g. through Like or Announce). These are always wrapped in a Create.
* lib/pleroma/web/activity_pub/mrf/reject_non_public.ex
    * We don't allow changing scope with Update, so not relevant here
floatingghost commented 2022-12-09 10:31:01 +00:00
Owner
Copy link

oops, i may have broken the PR by attempting to fix the lint by trying to rebase on develop

praise gitea (https://github.com/go-gitea/gitea/issues/18802)

this looks good though - i'm going to hit merge but i'm gonna have to do it via the cli hehe

oops, i may have broken the PR by attempting to fix the lint by trying to rebase on develop praise gitea (https://github.com/go-gitea/gitea/issues/18802) this looks good though - i'm going to hit merge but i'm gonna have to do it via the cli hehe
floatingghost commented 2022-12-09 10:31:51 +00:00
Owner
Copy link

merged via cli - d5828f1c5e

merged via cli - https://akkoma.dev/AkkomaGang/akkoma/commit/d5828f1c5e54ca236e50ef7837bfba3d1e665854
floatingghost closed this pull request 2022-12-09 10:31:51 +00:00
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#354
No description provided.
Delete branch "ilja/akkoma:fix_tagpolicy_to_also_work_on_updates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?