create_service_actor is now type Application #457

Closed

ilja wants to merge 1 commits from ilja:fix_relay_should_be_type_application into develop

ilja commented

2023-02-02 15:39:16 +00:00

Contributor

Fix #416

This is (only) used for internal fetch and for relay[1]. Both represent the instance and therefore are an application.

Change actor_type
Write migration
Notify relay maintainers https://git.pleroma.social/pleroma/relay/-/issues/36

[1]

$ grep -R 'get_or_create_service_actor_by_ap_id' lib
lib/pleroma/web/activity_pub/internal_fetch_actor.ex:    |> User.get_or_create_service_actor_by_ap_id("internal.fetch")
lib/pleroma/web/activity_pub/relay.ex:  def get_actor, do: User.get_or_create_service_actor_by_ap_id(ap_id(), @nickname)
lib/pleroma/user.ex:  @spec get_or_create_service_actor_by_ap_id(String.t(), String.t()) :: User.t() | nil
lib/pleroma/user.ex:  def get_or_create_service_actor_by_ap_id(uri, nickname) do

Fix https://akkoma.dev/AkkomaGang/akkoma/issues/416 This is (only) used for internal fetch and for relay[1]. Both represent the instance and therefore are an application. * [x] Change actor_type * [x] Write migration * [x] Notify relay maintainers <https://git.pleroma.social/pleroma/relay/-/issues/36> [1] ``` $ grep -R 'get_or_create_service_actor_by_ap_id' lib lib/pleroma/web/activity_pub/internal_fetch_actor.ex: |> User.get_or_create_service_actor_by_ap_id("internal.fetch") lib/pleroma/web/activity_pub/relay.ex: def get_actor, do: User.get_or_create_service_actor_by_ap_id(ap_id(), @nickname) lib/pleroma/user.ex: @spec get_or_create_service_actor_by_ap_id(String.t(), String.t()) :: User.t() | nil lib/pleroma/user.ex: def get_or_create_service_actor_by_ap_id(uri, nickname) do ```

ilja force-pushed fix_relay_should_be_type_application from fc1b2ea2c0 to f0d72b308e

2023-02-02 16:40:47 +00:00

Compare

ilja commented

2023-02-02 16:43:33 +00:00

Author

Contributor

I see two tests failing, but they also fail on develop, so doesn't seem related to this...

test/pleroma/web/activity_pub/object_validators/block_validation_test.exs:23
test/pleroma/web/common_api_test.exs:72

I see two tests failing, but they also fail on develop, so doesn't seem related to this... ``` test/pleroma/web/activity_pub/object_validators/block_validation_test.exs:23 test/pleroma/web/common_api_test.exs:72 ```