AkkomaGang/akkoma
AkkomaGang
/
akkoma
13
63
Fork 84
Code Issues 172 Pull Requests 15 Packages Projects 2 Releases 13 Wiki Activity

Show bubble_timeline in the api if any instances are set in it #502

Merged
floatingghost merged 4 commits from foxing/akkoma:foxing-patch-1 into develop 2023-03-21 10:13:42 +00:00
Conversation 1 Commits 4 Files Changed 1 +3
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/pleroma/web/mastodon_api/views/instance_view.ex
View File

@ -67,6 +67,9 @@ defmodule Pleroma.Web.MastodonAPI.InstanceView do
"pleroma:api/v1/notifications:include_types_filter",
"quote_posting",
"editing",
if !Enum.empty?(Config.get([:instance, :local_bubble], [])) do
foxing marked this conversation as resolved Outdated
floatingghost commented 2023-03-13 00:30:38 +00:00
Outdated
Review
Copy Link

it would probably be better to use Enum.empty? here, it's not recommended to check against an array literal

it would probably be better to use `Enum.empty?` here, it's not recommended to check against an array literal
foxing commented 2023-03-13 03:24:32 +00:00
Outdated
Review
Copy Link

I am not that well versed in elixir but I will have a look and try on my own instance, this was the best way I could find on my own since it should return the same if the list is empty or the config is completely undefined but the suggestion is helpful.

I am not that well versed in elixir but I will have a look and try on my own instance, this was the best way I could find on my own since it should return the same if the list is empty or the config is completely undefined but the suggestion is helpful.
foxing commented 2023-03-13 03:41:08 +00:00
Outdated
Review
Copy Link

Ok, less complicated than I expected, I have changed it, and it does work as expected on my instance.

Ok, less complicated than I expected, I have changed it, and it does work as expected on my instance.
"bubble_timeline"
end,
if Config.get([:media_proxy, :enabled]) do
"media_proxy"
end,