AkkomaGang/akkoma
AkkomaGang/akkoma
15
65
Fork 92
Code Issues 176 Pull requests 24 Projects 2 Releases 14 Packages Wiki Activity

don't crash on malformed avatar and banner values #506

Merged
floatingghost merged 1 commit from flisk/akkoma:fix-crash-malformed-avatars-banners into develop 2023-03-13 00:28:17 +00:00
Conversation 2 Commits 1 Files changed 2 +22 -12
flisk commented 2023-03-12 17:20:27 +00:00
Contributor
Copy link

weird values in href will cause base64 encoding to fail later down the
line, so let's make sure the value we're passing on is somewhat sane, or
at the very least a binary

this fixes #482

weird values in href will cause base64 encoding to fail later down the line, so let's make sure the value we're passing on is somewhat sane, or at the very least a binary this fixes #482
flisk added 1 commit 2023-03-12 17:20:27 +00:00
don't crash on malformed avatar and banner values
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
0c77be9308 
weird values in href will cause base64 encoding to fail later down the
line, so let's make sure the value we're passing on is somewhat sane, or
at the very least a binary

this fixes #482
flisk commented 2023-03-12 17:23:22 +00:00
Author
Contributor
Copy link

oh yeah and i took the liberty of refactoring that code a little along with the fix, hope that's cool

oh yeah and i took the liberty of refactoring that code a little along with the fix, hope that's cool
floatingghost commented 2023-03-13 00:28:13 +00:00
Owner
Copy link

this seems good, thanks a lot!

this seems good, thanks a lot!
floatingghost merged commit c5769bbf6d into develop 2023-03-13 00:28:17 +00:00
floatingghost deleted branch fix-crash-malformed-avatars-banners 2023-03-13 00:28:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#506
No description provided.
Delete branch "flisk/akkoma:fix-crash-malformed-avatars-banners"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?