AkkomaGang
/
akkoma
11
54
Fork 75
Code Issues 145 Pull Requests 19 Packages Projects 2 Releases 10 Wiki Activity

Docs: Improve backup restore + fix warnings #554

Open
ilja wants to merge 2 commits from ilja/akkoma:docs_db_create_in_separate_commands into develop
pull from: ilja/akkoma:docs_db_create_in_separate_commands
merge into: AkkomaGang:develop
Conversation 0 Commits 2 Files Changed 4
ilja commented 2023-05-29 06:53:14 +00:00

CREATE DATABASE was running in a transaction block with CREATE USER. Someone in the chat had problems with this because this isn't allowed (any more?). This is now two separate commands. I also did some other touch-ups to this file, including

  • making it OTP-first,
  • add backup of static directory because this contains e.g. custom emoji, and
  • remove the suggestion for using the setup_db.psql file. The reason is because I fear it causes more confusion than what it's worth.
    • Firstly, OTP installations won't have this file because it's created in /tmp.
    • Secondly, the instance has been reinstalled and thus a new setup_db.psql with different password will have been created, causing only more confusion.

When building the docs, I noticed two warnings, these are now also fixed.

  • One was a link to a file in the source code that didn't exist as far as mkdocs is concerned. This now links to the file in the git repo.
  • The other was because one of the font files wasn't found. I think it first tries to load them from your own system (which may explain why I only had an error on one of them, but I didn't check deeper), so it's possible that some people won't see changes, but those who didn't have the font on their system (like me), will see it.
CREATE DATABASE was running in a transaction block with CREATE USER. Someone in the chat had problems with this because this isn't allowed (any more?). This is now two separate commands. I also did some other touch-ups to this file, including * making it OTP-first, * add backup of static directory because this contains e.g. custom emoji, and * remove the suggestion for using the setup_db.psql file. The reason is because I fear it causes more confusion than what it's worth. * Firstly, OTP installations won't have this file because it's created in /tmp. * Secondly, the instance has been reinstalled and thus a new setup_db.psql with different password will have been created, causing only more confusion. When building the docs, I noticed two warnings, these are now also fixed. * One was a link to a file in the source code that didn't exist as far as mkdocs is concerned. This now links to the file in the git repo. * The other was because one of the font files wasn't found. I think it first tries to load them from your own system (which may explain why I only had an error on one of them, but I didn't check deeper), so it's possible that some people won't see changes, but those who didn't have the font on their system (like me), will see it.
ilja force-pushed docs_db_create_in_separate_commands from 74f95ec156 to 3947012691 2023-05-29 07:10:17 +00:00 Compare
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change
   
bug

Something is not working   
configuration

This requires config changes   
documentation

This is about human-readable docs   
duplicate

This issue or pull request already exists   
enhancement

New feature   
extremely low priority
   
feature request

Something new?   
Fix it yourself

Support has been attempted   
help wanted

Need some help   
invalid

Something is wrong   
mastodon_api
   
needs docs
   
needs tests
   
not a bug
   
planned
   
pleroma_api
   
privacy
   
question

More information is needed   
static_fe
   
triage
   
wontfix

This won't be fixed
No Label
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#554
There is no content yet.
Delete Branch "ilja/akkoma:docs_db_create_in_separate_commands"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?