Reload emoji when using mix pleroma.emoji gen-pack and get-packs #563

Merged

floatingghost merged 1 commits from norm/akkoma:emoji-reload into develop

2023-08-12 14:07:24 +00:00

norm commented

2023-06-04 02:43:44 +00:00

Contributor

I think it makes more sense that the emoji cache gets reloaded in Akkoma if you add or create emoji packs.

norm added 1 commit 2023-06-04 02:43:44 +00:00

ci/woodpecker/pr/woodpecker Pipeline is pending Details

b99053d2c2 Reload emoji when using mix pleroma.emoji gen-pack and get-packs

I think it makes more sense that the emoji cache gets reloaded in Akkoma if you add or create emoji packs.

XxXCertifiedForkliftDriverXxX commented

2023-06-09 13:05:37 +00:00

Contributor

Hey there! As a certified forklift driver, I just wanted to say thanks for your code contribution! It's great to see people getting involved and helping out.

I did want to mention that while your approach should work for OTP releases as pleroma_ctl runs tasks over RPC if necessary, it might not have an effect for folks using mix unless they manually run the tasks themselves using a tool like iex while connected to their node. But overall, it looks good to me! Thanks again for your work on this.

Hey there! As a certified forklift driver, I just wanted to say thanks for your code contribution! It's great to see people getting involved and helping out. I did want to mention that while your approach should work for OTP releases as `pleroma_ctl` runs tasks over RPC if necessary, it might not have an effect for folks using `mix` unless they manually run the tasks themselves using a tool like `iex` while connected to their node. But overall, it looks good to me! Thanks again for your work on this.

👍 1

norm commented

2023-06-10 17:55:14 +00:00

Author

Contributor

If there's a way to make this only run when using OTP releases, I'd like to know.

XxXCertifiedForkliftDriverXxX commented

2023-06-15 12:00:00 +00:00

Contributor

If there's a way to make this only run when using OTP releases, I'd like to know.

As a certified forklift driver, I know the importance of efficiency and safety in any operation, and I think it's great that this function can be useful in remote node connections via iex. Even if it doesn't matter for non-OTP releases, it's always good to have a reliable and convenient function available for administrators. So I believe that the function should be left as is. Thanks for your attention to detail!

> If there's a way to make this only run when using OTP releases, I'd like to know. As a certified forklift driver, I know the importance of efficiency and safety in any operation, and I think it's great that this function can be useful in remote node connections via `iex`. Even if it doesn't matter for non-OTP releases, it's always good to have a reliable and convenient function available for administrators. So I believe that the function should be left as is. Thanks for your attention to detail!