AkkomaGang/akkoma
AkkomaGang/akkoma
15
66
Fork 94
Code Issues 180 Pull requests 28 Projects 2 Releases 14 Packages Wiki Activity

Make search result order match the order of objects received from Meilisearch #579

Open
AdamK2003 wants to merge 1 commit from AdamK2003/akkoma:meilisearch-result-order into develop
pull from: AdamK2003/akkoma:meilisearch-result-order
merge into: AkkomaGang:develop
Conversation 1 Commits 1 Files changed 1 +7 -2
AdamK2003 commented 2023-07-04 10:04:40 +00:00
First-time contributor
Copy link

The search results are normally sorted by published date before getting to the client, which makes the result order not match the Meilisearch result order if you tweak your Meilisearch ranking settings. This PR sorts the results back into the initial Meilisearch order after fetching them from the repo.

The search results are normally sorted by published date before getting to the client, which makes the result order not match the Meilisearch result order if you tweak your Meilisearch ranking settings. This PR sorts the results back into the initial Meilisearch order after fetching them from the repo.
AdamK2003 added 1 commit 2023-07-04 10:04:41 +00:00
Fix search result order for Meilisearch
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
Details
7dd439807f
Oneric commented 2024-05-04 00:04:38 +00:00
Member
Copy link

@AdamK2003 can you test whether f32335742d also works for you? It directly fetches results in the correct order instead of using a O(n²) resort afterwards, but i don’t have Meilisearch set up.

EDIT: i was now able to confirm this works myself, see #772

@AdamK2003 can you test whether https://akkoma.dev/Oneric/akkoma/commit/f32335742daf8b037b136584f859cb59666edf65 also works for you? It directly fetches results in the correct order instead of using a O(n²) resort afterwards, but i don’t have Meilisearch set up. **EDIT:** i was now able to confirm this works myself, see #772
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
Details
This pull request has changes conflicting with the target branch.
  • lib/pleroma/search/meilisearch.ex
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u meilisearch-result-order:AdamK2003-meilisearch-result-order
git checkout AdamK2003-meilisearch-result-order
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#579
No description provided.
Delete branch "AdamK2003/akkoma:meilisearch-result-order"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?