Add docker-compose.yml to gitignore #617

Closed

norm wants to merge 1 commits from norm:docker-compose-example into develop

norm commented

2023-08-06 13:27:34 +00:00

Contributor

The docker-compose.yml file is likely to be edited quite extensively by
admins when setting up an instance. To make it easier to do upgrades
down the line, it should be ignored by git.

Instead we should provide the existing docker-compose.yml as a sample
config and update the docs to have the user copy it over to the root
directory to edit it themselves.

The docker-compose.yml file is likely to be edited quite extensively by admins when setting up an instance. To make it easier to do upgrades down the line, it should be ignored by git. Instead we should provide the existing docker-compose.yml as a sample config and update the docs to have the user copy it over to the root directory to edit it themselves.

norm force-pushed docker-compose-example from 1765300430 to da89d21332

2023-08-06 13:30:30 +00:00

Compare

floatingghost commented

2023-08-07 15:26:18 +00:00

Owner

i think there are better ways of handling this - for example weblate handles this very thing via having an "overrides" docker-compose file, which then get passed into docker via the -f argument

we probably don't want to desync the base compose file, so this might be a cleaner way to do it

i think there are better ways of handling this - for example [weblate](https://github.com/WeblateOrg/docker-compose) handles this very thing via having an "overrides" docker-compose file, which then get passed into docker via [the -f argument](https://docs.docker.com/compose/multiple-compose-files/extends/) we probably don't want to desync the base compose file, so this might be a cleaner way to do it

👍 1