Fix invalid Date HTTP header when signing fetch requests #619

Merged

floatingghost merged 1 commits from Clovis/akkoma:fix-503 into develop

2023-08-07 15:23:21 +00:00

Clovis commented

2023-08-07 12:46:52 +00:00

Contributor

Fix #503

While trying to follow a relay, I encountered the same error. I was able to mitigate it by deactivating the ActivityPub.SignObjectFetch setting.

From what I understand, this bug is encountered on non-english servers because of those lines:

https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/lib/pleroma/object/fetcher.ex#L271-L276

https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/lib/pleroma/object/fetcher.ex#L230-L236

https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/lib/pleroma/signature.ex#L78-L80

Having the Pleroma.Config.get([:activitypub, :sign_object_fetches]) set to true cause the server to add a Date header on its requests. However, it seems that this date is translated at some point (probably following OS locale settings). On my config it generates lun., 07 août 2023 10:32:16 GMT (for monday, 07 august) with "û" not being a valid ASCII char.

This bug seems to be rather important since in the current state, we do not follow the Date HTTP header format in some cases: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Date

Fix https://akkoma.dev/AkkomaGang/akkoma/issues/503 While trying to follow a relay, I encountered the same error. I was able to mitigate it by deactivating the `ActivityPub.SignObjectFetch` setting. From what I understand, this bug is encountered on non-english servers because of those lines: https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/lib/pleroma/object/fetcher.ex#L271-L276 https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/lib/pleroma/object/fetcher.ex#L230-L236 https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/lib/pleroma/signature.ex#L78-L80 Having the `Pleroma.Config.get([:activitypub, :sign_object_fetches])` set to true cause the server to add a `Date` header on its requests. However, it seems that this date is translated at some point (probably following OS locale settings). On my config it generates `lun., 07 août 2023 10:32:16 GMT` (for monday, 07 august) with "û" not being a valid ASCII char. This bug seems to be rather important since in the current state, we do not follow the Date HTTP header format in some cases: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Date

❤️ 1

Clovis added 1 commit 2023-08-07 12:46:53 +00:00

ci/woodpecker/pr/test Pipeline failed Details

ci/woodpecker/pr/build-arm64 unknown status Details

ci/woodpecker/pr/build-amd64 unknown status Details

ci/woodpecker/pr/docs unknown status Details

fc3cc61768 Fix invalid Date HTTP header when signing fetch requests

#503

floatingghost commented

2023-08-07 15:22:59 +00:00

Owner

i was about to type "could you add a test" but apparently we already have one and it would have failed if your locale wasn't EN i guess

funny that nobody found that failure sooner

thanks!

i was about to type "could you add a test" but apparently we [already have one](https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/test/pleroma/signature_test.exs#L133) and it would have failed if your locale wasn't EN i guess funny that nobody found that failure sooner thanks!

floatingghost merged commit 3f1e2b0b3b into develop

2023-08-07 15:23:21 +00:00

floatingghost deleted branch fix-503

2023-08-07 15:23:21 +00:00

floatingghost referenced this issue from a commit

2023-08-07 15:23:21 +00:00

Merge pull request 'Fix invalid Date HTTP header when signing fetch requests' (#619) from Clovis/akkoma:fix-503 into develop

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#619

No description provided.