AkkomaGang/akkoma
AkkomaGang/akkoma
15
64
Fork 91
Code Issues 175 Pull requests 19 Projects 2 Releases 14 Packages Wiki Activity

Fix #strip_report_status_data #665

Open
NEETzsche wants to merge 1 commit from NEETzsche/akkoma:neetzsche/fix-anonymous-exception into develop
pull from: NEETzsche/akkoma:neetzsche/fix-anonymous-exception
merge into: AkkomaGang:develop
Conversation 0 Commits 1 Files changed 1 +1
NEETzsche commented 2023-11-27 10:51:31 +00:00
First-time contributor
Copy link

It was erroring in the anonymous function on breastmilk.club when trying to close a report:

** (exit) an exception was raised:
    ** (FunctionClauseError) no function clause matching in anonymous fn/1 in Pleroma.Web.ActivityPub.Utils.strip_report_status_data/1
        (pleroma 3.7.1-202-g3cc88b37-akroma) lib/pleroma/web/activity_pub/utils.ex:829: anonymous fn(nil) in Pleroma.Web.ActivityPub.Utils.strip_report_status_data/1
        (elixir 1.14.3) lib/enum.ex:1658: Enum."-map/2-lists^map/1-0-"/2
        (pleroma 3.7.1-202-g3cc88b37-akroma) lib/pleroma/web/activity_pub/utils.ex:829: Pleroma.Web.ActivityPub.Utils.strip_report_status_data/1
        (pleroma 3.7.1-202-g3cc88b37-akroma) lib/pleroma/web/activity_pub/utils.ex:791: Pleroma.Web.ActivityPub.Utils.update_report_state/2
        (pleroma 3.7.1-202-g3cc88b37-akroma) lib/pleroma/web/admin_api/controllers/report_controller.ex:51: anonymous fn/2 in Pleroma.Web.AdminAPI.ReportController.update/2
        (elixir 1.14.3) lib/enum.ex:1658: Enum."-map/2-lists^map/1-0-"/2
        (pleroma 3.7.1-202-g3cc88b37-akroma) lib/pleroma/web/admin_api/controllers/report_controller.ex:50: Pleroma.Web.AdminAPI.ReportController.update/2
        (pleroma 3.7.1-202-g3cc88b37-akroma) lib/pleroma/web/admin_api/controllers/report_controller.ex:5: Pleroma.Web.AdminAPI.ReportController.action/2

This PR fixes that bug. Apparently it ran into a case other than the two listed. This fixes that. breastmilk.club runs on Akkoma.

It was erroring in the anonymous function on `breastmilk.club` when trying to close a report: ``` ** (exit) an exception was raised: ** (FunctionClauseError) no function clause matching in anonymous fn/1 in Pleroma.Web.ActivityPub.Utils.strip_report_status_data/1 (pleroma 3.7.1-202-g3cc88b37-akroma) lib/pleroma/web/activity_pub/utils.ex:829: anonymous fn(nil) in Pleroma.Web.ActivityPub.Utils.strip_report_status_data/1 (elixir 1.14.3) lib/enum.ex:1658: Enum."-map/2-lists^map/1-0-"/2 (pleroma 3.7.1-202-g3cc88b37-akroma) lib/pleroma/web/activity_pub/utils.ex:829: Pleroma.Web.ActivityPub.Utils.strip_report_status_data/1 (pleroma 3.7.1-202-g3cc88b37-akroma) lib/pleroma/web/activity_pub/utils.ex:791: Pleroma.Web.ActivityPub.Utils.update_report_state/2 (pleroma 3.7.1-202-g3cc88b37-akroma) lib/pleroma/web/admin_api/controllers/report_controller.ex:51: anonymous fn/2 in Pleroma.Web.AdminAPI.ReportController.update/2 (elixir 1.14.3) lib/enum.ex:1658: Enum."-map/2-lists^map/1-0-"/2 (pleroma 3.7.1-202-g3cc88b37-akroma) lib/pleroma/web/admin_api/controllers/report_controller.ex:50: Pleroma.Web.AdminAPI.ReportController.update/2 (pleroma 3.7.1-202-g3cc88b37-akroma) lib/pleroma/web/admin_api/controllers/report_controller.ex:5: Pleroma.Web.AdminAPI.ReportController.action/2 ``` This PR fixes that bug. Apparently it ran into a case other than the two listed. This fixes that. `breastmilk.club` runs on Akkoma.
NEETzsche added 1 commit 2023-11-27 10:51:32 +00:00
Fix #strip_report_status_data
Some checks are pending
ci/woodpecker/pr/build-amd64 Pipeline is pending
Details
ci/woodpecker/pr/build-arm64 Pipeline is pending
Details
ci/woodpecker/pr/docs Pipeline is pending
Details
ci/woodpecker/pr/lint Pipeline is pending
Details
ci/woodpecker/pr/test Pipeline is pending
Details
9f6a557ce1
Some checks are pending
ci/woodpecker/pr/build-amd64 Pipeline is pending
Details
ci/woodpecker/pr/build-arm64 Pipeline is pending
Details
ci/woodpecker/pr/docs Pipeline is pending
Details
ci/woodpecker/pr/lint Pipeline is pending
Details
ci/woodpecker/pr/test Pipeline is pending
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u neetzsche/fix-anonymous-exception:NEETzsche-neetzsche/fix-anonymous-exception
git checkout NEETzsche-neetzsche/fix-anonymous-exception
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#665
No description provided.
Delete branch "NEETzsche/akkoma:neetzsche/fix-anonymous-exception"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?