Fix OAuth consumer mode #668

Merged

floatingghost merged 4 commits from :develop into develop

2024-02-02 10:05:42 +00:00

tcmal commented

2023-12-17 19:39:36 +00:00

Contributor

We now set a cookie with the state we need to keep track of, and read it once the callback happens.

Fixes #646

The previous code passed a state parameter to ueberauth with info about where to go after the user logged in, etc. Since ueberauth 0.7, this parameter is ignored and oauth state is used for CSRF prevention, see [here](https://github.com/ueberauth/ueberauth/pull/136). We now set a cookie with the state we need to keep track of, and read it once the callback happens. Fixes #646

tcmal added 3 commits 2023-12-17 19:39:36 +00:00

e2f749b5b0 don't select ueberauth 0.10.6, as it is broken

see https://github.com/ueberauth/ueberauth/issues/194

eb0dbf6b79 fix oauth consumer mode

the previous code passed a state parameter to ueberauth with info
about where to go after the user logged in, etc.
since ueberauth 0.7, this parameter is ignored and oauth state is used
for actual CSRF reasons.

we now set a cookie with the state we need to keep track of, and read
it once the callback happens.

a074be24ca add bit about frontend configuration to oauth consumer docs

tcmal added 1 commit 2023-12-17 21:48:46 +00:00

ci/woodpecker/pr/lint Pipeline was successful Details

ci/woodpecker/pr/test Pipeline was successful Details

ci/woodpecker/pr/build-arm64 unknown status Details

ci/woodpecker/pr/build-amd64 unknown status Details

ci/woodpecker/pr/docs unknown status Details

77000b8ffd update tests for oauth consumer

tcmal changed title from ~~WIP: Fix OAuth consumer mode~~ to Fix OAuth consumer mode

2023-12-17 21:48:50 +00:00

floatingghost commented

2023-12-29 16:12:29 +00:00

Owner

thanks! this passes all tests, lemme like spin up a way to actually test this and i'll make sure everything looks ok

(i'll be honest this auth mode has been neglected since way before this fork existed)

thanks! this passes all tests, lemme like spin up a way to actually test this and i'll make sure everything looks ok (i'll be honest this auth mode has been neglected since way before this fork existed)

floatingghost merged commit b4ccddab39 into develop

2024-02-02 10:05:42 +00:00

floatingghost referenced this issue from a commit

2024-02-02 10:05:44 +00:00

Merge pull request 'Fix OAuth consumer mode' (#668) from tcmal/akkoma:develop into develop

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#668

No description provided.