Allow fetching over IPv6 #708

Closed
Oneric wants to merge 0 commits from Oneric:ipv6 into develop
Member

As reportedo n IRC by KitsuWhooa, fetching from IPv6-only hosts is broken otherwise.
Why does Mint disable IPv6 by default?, idk

I’m a bit confused about whether there even can be a different pool than default atm and if not, why all the maybe_adds are needed. To make sure its added to (hopefully, assuming they call add_transport_opts) all pools, inet6: true is directly set by maybe_add_transport_opts regardless of if any transport opts were set before.

Depending on what needs to be supported, the whole maybe_add setup logic could perhaps be simplified to a deep merge with some default settings.

As reportedo n IRC by KitsuWhooa, fetching from IPv6-only hosts is broken otherwise. Why does Mint disable IPv6 by default?, idk I’m a bit confused about whether there even can be a different pool than `default` atm and if not, why all the `maybe_add`s are needed. To make sure its added to *(hopefully, assuming they call `add_transport_opts`)* all pools, `inet6: true` is directly set by `maybe_add_transport_opts` regardless of if any transport opts were set before. Depending on what needs to be supported, the whole `maybe_add` setup logic could perhaps be simplified to a deep merge with some default settings.
Oneric force-pushed ipv6 from 23632e4e92 to fc95519dbf 2024-02-25 22:51:03 +00:00 Compare

merged via 1135935cbe

merged via 1135935cbe66043708ab0729e12b476e2d55a54c
floatingghost closed this pull request 2024-04-11 20:00:45 +00:00
Oneric deleted branch ipv6 2024-04-11 20:51:30 +00:00
All checks were successful
ci/woodpecker/pr/lint Pipeline was successful
ci/woodpecker/pr/test Pipeline was successful
ci/woodpecker/pr/build-amd64 Pipeline was successful
ci/woodpecker/pr/build-arm64 Pipeline was successful
ci/woodpecker/pr/docs Pipeline was successful

Pull request closed

Sign in to join this conversation.
No description provided.