Don't strip newlines in pre #709

Merged

floatingghost merged 1 commits from snan/akkoma:pre into develop

2024-04-24 17:00:34 +00:00

snan commented

2024-02-27 09:29:10 +00:00

Contributor

In the atom feed, that is

snan force-pushed pre from acf6390ad9 to b6b773f6ec

2024-02-27 09:32:57 +00:00

Compare

Oneric commented

2024-03-02 05:52:19 +00:00

Member

i was wondering why newlines are stripped at all, considering they have no effect in HTML outside of <pre> and XML should be able to handle them as well.
Apparently this was added 7 years ago to work around a bug in Mastodon; presumably for the OStatus use of this function and not the XML feed (which got split out later)

Given any OStatus bugs of Mastodon aren’t relevant anymore, can we just stop stripping newlines at all here?

i was wondering why newlines are stripped at all, considering they have no effect in HTML outside of `<pre>` and XML should be able to handle them as well. Apparently this was [added 7 years ago](https://akkoma.dev/AkkomaGang/akkoma/commit/368fa25f1f9aa69963165eadd677d315a4f994f7) to work around a bug in Mastodon; presumably for the OStatus use of this function and not the XML feed (which got split out [later](https://akkoma.dev/AkkomaGang/akkoma/commit/4b3f77a99ff849f7593f63f7dccd206683b34d97)) Given any OStatus bugs of Mastodon aren’t relevant anymore, can we just stop stripping newlines at all here?

👍 1

snan force-pushed pre from 53cef182f3 to 8dd74f0d41

2024-03-11 11:35:35 +00:00

Compare

snan commented

2024-03-11 11:37:14 +00:00

Author

Contributor

(If people prefer b6b773f6ec lmk, I can get it back 💁🏻‍♀️)

snan force-pushed pre from 8dd74f0d41 to 6116f81546

2024-03-11 11:51:44 +00:00

Compare