AkkomaGang/akkoma
AkkomaGang
/
akkoma
12
63
Fork 83
Code Issues 173 Pull Requests 13 Packages Projects 2 Releases 12 Wiki Activity

context: add featured definition #717

Merged
floatingghost merged 1 commits from erincandescent/akkoma:context-featured into develop 2024-04-03 10:22:10 +00:00
Conversation 7 Commits 1 Files Changed 1 +9
erincandescent commented 2024-03-02 20:59:09 +00:00
Contributor
Copy Link

This was missing from our context, which caused interoperability issues for people who do context-based JSON-LD processing

This was missing from our context, which caused interoperability issues for people who do context-based JSON-LD processing
erincandescent added 1 commit 2024-03-02 20:59:09 +00:00
ci/woodpecker/pr/build-amd64 Pipeline is pending Details
ci/woodpecker/pr/build-arm64 Pipeline is pending Details
ci/woodpecker/pr/docs Pipeline is pending Details
ci/woodpecker/pr/lint Pipeline is pending Details
ci/woodpecker/pr/test Pipeline is pending Details
94b326ddde context: add featured definition 
This was missing from our context, which caused interoperability issues with
people who do context processing
Oneric commented 2024-03-02 22:24:48 +00:00
Member
Copy Link

I guess the followigng should also be added then to account for #682?

sharkey: "https://joinsharkey.org/ns#",
backgroundUrl: "sharkey:backgroundUrl",
I guess the followigng should also be added then to account for #682? ```json sharkey: "https://joinsharkey.org/ns#", backgroundUrl: "sharkey:backgroundUrl", ```
erincandescent commented 2024-03-02 22:42:27 +00:00
Author
Contributor
Copy Link

oh yeah likely, will follow up with that

oh yeah likely, will follow up with that
👍 1
Oneric commented 2024-03-09 15:46:25 +00:00
Member
Copy Link

I just learned litepub-0.1.jsonld isn’t just an *oma thing but comes from https://litepub.social/

At the one hand, adding non-standard stuff to it maybe confusing, on the other hand LitePub is stalled for soon 5 years so it might not matter anyway.
JSON not having first-class comments makes adding a delimiter between standard LitePub and our extensions a bit more diffuclt. Mayhaps we can add a second file, or maybe it doesn’t matter at all?

I just learned `litepub-0.1.jsonld` isn’t just an \*oma thing but comes from https://litepub.social/ At the one hand, adding non-standard stuff to it maybe confusing, on the other hand LitePub is stalled for soon 5 years so it might not matter anyway. JSON not having first-class comments makes adding a delimiter between standard LitePub and our extensions a bit more diffuclt. Mayhaps we can add a second file, or maybe it doesn’t matter at all?
erincandescent commented 2024-03-09 15:52:31 +00:00
Author
Contributor
Copy Link

I was thinking about that; it would be aesthetically pleasing to rename the file. But I wanted to separate that change

I was thinking about that; it would be aesthetically pleasing to rename the file. But I wanted to separate that change
erincandescent commented 2024-03-09 15:53:14 +00:00
Author
Contributor
Copy Link

(by the way sorry for not following up on these - I was on a business trip to Paris)

(by the way sorry for not following up on these - I was on a business trip to Paris)
Oneric commented 2024-03-09 16:01:33 +00:00
Member
Copy Link

(by the way sorry for not following up on these - I was on a business trip to Paris)

no worries, all good

> (by the way sorry for not following up on these - I was on a business trip to Paris) no worries, all good
erincandescent force-pushed context-featured from 94b326ddde to 8fbd771d6e 2024-04-01 11:39:54 +00:00 Compare
Oneric approved these changes 2024-04-01 23:28:57 +00:00
floatingghost commented 2024-04-03 10:22:04 +00:00
Owner
Copy Link

yep, all good, thanks!

yep, all good, thanks!
floatingghost merged commit b8393ad9ed into develop 2024-04-03 10:22:10 +00:00
floatingghost deleted branch context-featured 2024-04-03 10:22:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Oneric
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No Label
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#717
No description provided.
Delete Branch "erincandescent/akkoma:context-featured"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?