AkkomaGang/akkoma
AkkomaGang/akkoma
15
65
Fork 92
Code Issues 176 Pull requests 24 Projects 2 Releases 14 Packages Wiki Activity

Accept body parameters for /api/pleroma/notification_settings #738

Merged
floatingghost merged 1 commit from Oneric/akkoma:notif-setting-parameters into develop 2024-04-13 22:55:02 +00:00
Conversation 1 Commits 1 Files changed 3 +99 -3
Oneric commented 2024-04-09 02:16:32 +00:00
Member
Copy link

This brings it in line with its documentation and akkoma-fe’s expectations. For backwards-compatibility URL parameters are also still
accept with lower priority. Unfortunately this means duplicating the parameters and description in the API spec.

Usually Plug already pre-merges parameters from different sources into the plain params parameter which also gets forwarded by Phoenix.
However OpenApiSpex 3.x prevents this albeit a change is planned for 4.x, see:
https://github.com/open-api-spex/open_api_spex/issues/334
https://github.com/open-api-spex/open_api_spex/issues/92

Fixes: #691
Fixes: #722

This brings it in line with its documentation and akkoma-fe’s expectations. For backwards-compatibility URL parameters are also still accept with lower priority. Unfortunately this means duplicating the parameters and description in the API spec. Usually Plug already pre-merges parameters from different sources into the plain params parameter which also gets forwarded by Phoenix. However OpenApiSpex 3.x prevents this albeit a change is planned for 4.x, see: https://github.com/open-api-spex/open_api_spex/issues/334 https://github.com/open-api-spex/open_api_spex/issues/92 Fixes: https://akkoma.dev/AkkomaGang/akkoma/issues/691 Fixes: https://akkoma.dev/AkkomaGang/akkoma/issues/722
Oneric added 1 commit 2024-04-09 02:16:33 +00:00
Accept body parameters for /api/pleroma/notification_settings
Some checks failed
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/build-amd64 unknown status
Details
ci/woodpecker/pr/build-arm64 unknown status
Details
ci/woodpecker/pr/docs unknown status
Details
bd74ad9ce4 
This brings it in line with its documentation and akkoma-fe’s
expectations. For backwards compatibility URL parameters are still
accept with lower priority. Unfortunately this means duplicating
parameters and descriptions in the API spec.

Usually Plug already pre-merges parameters from different sources into
the plain 'params' parameter which then gets forwarded by Phoenix.
However, OpenApiSpex 3.x prevents this; 4.x is set to change this
  https://github.com/open-api-spex/open_api_spex/issues/334
  https://github.com/open-api-spex/open_api_spex/issues/92

Fixes: #691
Fixes: #722
floatingghost commented 2024-04-13 22:54:59 +00:00
Owner
Copy link

all seems good, thanks!

all seems good, thanks!
floatingghost merged commit c1f0b6b875 into develop 2024-04-13 22:55:02 +00:00
floatingghost deleted branch notif-setting-parameters 2024-04-13 22:55:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#738
No description provided.
Delete branch "Oneric/akkoma:notif-setting-parameters"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?