AkkomaGang/akkoma
AkkomaGang/akkoma
15
65
Fork 91
Code Issues 175 Pull requests 22 Projects 2 Releases 14 Packages Wiki Activity

Fix Exiftool migration id #763

Merged
floatingghost merged 1 commit from Oneric/akkoma:fix-migration-timeline-exifdesc into develop 2024-05-06 22:51:06 +00:00
Conversation 1 Commits 1 Files changed 2 +43 -33
Oneric commented 2024-04-27 17:20:58 +00:00
Member
Copy link

See #744 (comment)

Applying works fine with a 20220220135625 version, but it won’t be
rolled back in the right order. Fortunately this action is idempotent
so we can just rename and reapply it with a new id.

To also not break large-scale rollbacks past 2022 for anyone
who already applied it with the old id, keep a stub migration.

See https://akkoma.dev/AkkomaGang/akkoma/pulls/744#issuecomment-11882 Applying works fine with a 20220220135625 version, but it won’t be rolled back in the right order. Fortunately this action is idempotent so we can just rename and reapply it with a new id. To also not break large-scale rollbacks past 2022 for anyone who already applied it with the old id, keep a stub migration.
floatingghost reviewed 2024-05-06 21:49:27 +00:00
priv/repo/migrations/20220220135625_upload_filter_exiftool_to_exiftool_strip_location.exs Outdated
@ -1,37 +1,10 @@
defmodule Pleroma.Repo.Migrations.UploadFilterExiftoolToExiftoolStripMetadata do
defmodule Pleroma.Repo.Migrations.UploadFilterExiftoolToExiftoolStripMetadataStub do
floatingghost commented 2024-05-06 21:49:05 +00:00
Owner
Copy link

gonna be pedantic

the filename should match the module name

also also, this filename causes migrations to fail from older versions - it works from current dev/stable, but not before

$ git checkout v3.12.2 # 2024.03
$ mix ecto.reset # get us a default DB
$ git checkout oneric/fix-migration-timeline-exifdesc
$ mix ecto.migrate
** (Ecto.MigrationError) migrations can't be executed, migration name upload_filter_exiftool_to_exiftool_strip_location is duplicated

running

mv 
priv/repo/migrations/20220220135625_upload_filter_exiftool_to_exiftool_strip_location.exs 
priv/repo/migrations/20220220135625_upload_filter_exiftool_to_exiftool_strip_location_stub.exs

causes this to succeed

gonna be pedantic the filename should match the module name also also, this filename causes migrations to fail from older versions - it works from current dev/stable, but not before ```bash $ git checkout v3.12.2 # 2024.03 $ mix ecto.reset # get us a default DB $ git checkout oneric/fix-migration-timeline-exifdesc $ mix ecto.migrate ** (Ecto.MigrationError) migrations can't be executed, migration name upload_filter_exiftool_to_exiftool_strip_location is duplicated ``` running ```bash mv priv/repo/migrations/20220220135625_upload_filter_exiftool_to_exiftool_strip_location.exs priv/repo/migrations/20220220135625_upload_filter_exiftool_to_exiftool_strip_location_stub.exs ``` causes this to succeed
Oneric commented 2024-05-06 22:34:19 +00:00
Author
Member
Copy link

good catch! If filenames can become important though, it’s probably safer to leave the original filename as is. So the 2022 version now keeps its name and module and filename of the 2024 are now changed to include a _real/Real suffix

migrations from 3.12.2 now work for me

good catch! If filenames can become important though, it’s probably safer to leave the original filename as is. So the 2022 version now keeps its name and module and filename of the 2024 are now changed to include a `_real`/`Real` suffix migrations from 3.12.2 now work for me
Oneric marked this conversation as resolved
Oneric force-pushed fix-migration-timeline-exifdesc from 905cbc6d60 to 5256678901 2024-05-06 22:31:56 +00:00 Compare
floatingghost commented 2024-05-06 22:51:02 +00:00
Owner
Copy link

indeedy they do :nod:

thankies

indeedy they do :nod: thankies
floatingghost merged commit ee03149ba1 into develop 2024-05-06 22:51:06 +00:00
floatingghost deleted branch fix-migration-timeline-exifdesc 2024-05-06 22:51:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#763
No description provided.
Delete branch "Oneric/akkoma:fix-migration-timeline-exifdesc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?