Handle errors from HTTP requests gracefully #791

Merged
floatingghost merged 5 commits from wp-embeds into develop 2024-06-07 12:58:58 +00:00

Fixes #790

Fixes #790
floatingghost added 3 commits 2024-06-04 13:31:04 +00:00
Don't error on rich media fail
Some checks are pending
ci/woodpecker/push/build-amd64 Pipeline is pending
ci/woodpecker/push/build-arm64 Pipeline is pending
ci/woodpecker/push/docs Pipeline is pending
ci/woodpecker/push/lint Pipeline is pending
ci/woodpecker/push/test Pipeline is pending
30e13a8785
am i baka
Some checks are pending
ci/woodpecker/push/build-amd64 Pipeline is pending
ci/woodpecker/push/build-arm64 Pipeline is pending
ci/woodpecker/push/docs Pipeline is pending
ci/woodpecker/push/lint Pipeline is pending
ci/woodpecker/push/test Pipeline is pending
0f7ae0fa21
Move rescue to the HTTP request itself
Some checks failed
ci/woodpecker/push/lint Pipeline was successful
ci/woodpecker/push/test Pipeline was successful
ci/woodpecker/push/build-amd64 Pipeline was successful
ci/woodpecker/push/build-arm64 Pipeline was successful
ci/woodpecker/push/docs Pipeline was successful
ci/woodpecker/pr/lint Pipeline failed
ci/woodpecker/pr/test unknown status
ci/woodpecker/pr/build-arm64 unknown status
ci/woodpecker/pr/build-amd64 unknown status
ci/woodpecker/pr/docs unknown status
c9a03af7c1
floatingghost added 1 commit 2024-06-04 13:34:37 +00:00
remove now-pointless clause
Some checks are pending
ci/woodpecker/push/build-amd64 Pipeline is pending
ci/woodpecker/push/build-arm64 Pipeline is pending
ci/woodpecker/push/docs Pipeline is pending
ci/woodpecker/push/lint Pipeline is pending
ci/woodpecker/push/test Pipeline is pending
ci/woodpecker/pr/build-amd64 Pipeline is pending
ci/woodpecker/pr/build-arm64 Pipeline is pending
ci/woodpecker/pr/docs Pipeline is pending
ci/woodpecker/pr/lint Pipeline is pending
ci/woodpecker/pr/test Pipeline is pending
38d09cb0ce
floatingghost added 1 commit 2024-06-04 13:35:08 +00:00
remove pointless logger
Some checks are pending
ci/woodpecker/push/build-amd64 Pipeline is pending
ci/woodpecker/push/build-arm64 Pipeline is pending
ci/woodpecker/push/docs Pipeline is pending
ci/woodpecker/push/lint Pipeline is pending
ci/woodpecker/push/test Pipeline is pending
ci/woodpecker/pr/lint Pipeline was successful
ci/woodpecker/pr/test Pipeline was successful
ci/woodpecker/pr/build-amd64 Pipeline was successful
ci/woodpecker/pr/build-arm64 Pipeline was successful
ci/woodpecker/pr/docs Pipeline was successful
0f65dd3ebe
Member

Worth noting the same issue was brought up before in the replies (but not OP!) of #533 and should now also be fixed
I can't reproduce the issue from #533’s OP anymore, but likely it would have been fixed with the rescue clause (also) in rich media generation

(And for reference #508 shows similar symptoms, but was an unrelated issue with media proxy previews iiuc, but (a) things now load fine on the linked instance, but (b) this instance is still at 3.10.4 and (c) i can’t check this myself since the original posts are deleted and only the linked cached copies remain. Right now some previews just show an empty box without a 500, but that’s because the original image is a zero-length object, possibly due to deletion; e.g. https://pbs.twimg.com/media/EiHIlxqU8AEgsga.jpg)

Worth noting the same issue was brought up before in the replies (but not OP!) of #533 and should now also be fixed I can't reproduce the issue from #533’s OP anymore, but likely it would have been fixed with the rescue clause (also) in rich media generation (And for reference #508 shows similar symptoms, but was an unrelated issue with media proxy previews iiuc, but (a) things now load fine on the linked instance, but (b) this instance is still at 3.10.4 and (c) i can’t check this myself since the original posts are deleted and only the linked cached copies remain. Right now some previews just show an empty box without a 500, but that’s because the original image is a zero-length object, possibly due to deletion; e.g. `https://pbs.twimg.com/media/EiHIlxqU8AEgsga.jpg`)
Author
Owner

whilst this doesn't perhaps fix the core issues of rich media being on-demand, this will never not be a good idea to have as an emergency catch

future development may include things mentioned in #790

whilst this doesn't perhaps fix the core issues of rich media being on-demand, this will never not be a good idea to have as an emergency catch future development may include things mentioned in #790
floatingghost merged commit f8f364d36d into develop 2024-06-07 12:58:58 +00:00
floatingghost deleted branch wp-embeds 2024-06-07 12:58:58 +00:00
Sign in to join this conversation.
No description provided.