AkkomaGang/akkoma
AkkomaGang/akkoma
17
70
Fork 119
Code Issues 148 Pull requests 16 Projects 2 Releases 24 Packages Wiki Activity

Fix StealEmoji’s max size check #793

Merged
floatingghost merged 3 commits from Oneric/akkoma:emojistealer_contentlength into develop 2024-06-12 17:09:06 +00:00
Conversation 1 Commits 3 Files changed 3 +21 -6
Oneric commented 2024-06-05 18:22:21 +00:00
Owner
Copy link

sorry, my bad, type confusion

i’m surprised this wasn’t reported earlier, seems barely anyone uses StealEmoji or maybe noone checked whether new ones got still added?

sorry, my bad, type confusion i’m surprised this wasn’t reported earlier, seems barely anyone uses StealEmoji or maybe noone checked whether new ones got still added?
All headers are strings, always.
In this case it didn't matter atm,
but let’s not provide confusing examples.
Headers are strings, but this expected to already get an int
thus always failing the comparison if the header was set.

Fixes mistake in d6d838cbe8
mrf/steal_emoji: display download_unknown_size in admin-fe
All checks were successful
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/build-amd64 Pipeline was successful
Details
ci/woodpecker/pr/build-arm64 Pipeline was successful
Details
ci/woodpecker/pr/docs Pipeline was successful
Details
df27567d99 
Fixes omission in d6d838cbe8
floatingghost commented 2024-06-12 17:09:02 +00:00
Owner
Copy link

hehe
figures
thanks

hehe figures thanks
floatingghost deleted branch emojistealer_contentlength 2024-06-12 17:09:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
broken setup

Issue arose from a misconfiguration by the admin, custom patches, manual db edits or similar

  
bug

Something is not working

  
cannot reproduce

   
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs change/feedback

Issue or PR is stalled on response from the author or a third party

  
needs docs

   
needs tests

   
not a bug

   
not our bug

Bug in a dependency of ours (meaning we can't just fix it), or in another AP implementation or client interfacing with Akkoma (which needs to be fixed on their end)

  
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
broken setup
bug
cannot reproduce
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs change/feedback
needs docs
needs tests
not a bug
not our bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AkkomaGang/akkoma!793
No description provided.