AkkomaGang/akkoma
AkkomaGang/akkoma
15
64
Fork 91
Code Issues 175 Pull requests 19 Projects 2 Releases 14 Packages Wiki Activity

Various small fixes and enhancements #814

Open
Oneric wants to merge 10 commits from Oneric/akkoma:varfixes into develop
pull from: Oneric/akkoma:varfixes
merge into: AkkomaGang:develop
Conversation 0 Commits 10 Files changed 29 +74 -41
Oneric commented 2024-06-20 17:59:59 +00:00
Member
Copy link

Several simple small changes, bundled into one PR to avoid manging a bunch of changelog conflicts

Other than the two Pleroma commits forming a unit, each commit stands on its own and can be freely reordered or merged individually (apart from potential conflicts in the Changelog)

EDIT: added a fix for the specific case from AkkomaGang/akkoma-fe#396

Several simple small changes, bundled into one PR to avoid manging a bunch of changelog conflicts Other than the two Pleroma commits forming a unit, each commit stands on its own and can be freely reordered or merged individually (apart from potential conflicts in the Changelog) **EDIT**: added a fix for the specific case from https://akkoma.dev/AkkomaGang/akkoma-fe/issues/396
Oneric added 8 commits 2024-06-20 18:00:00 +00:00 
Fragments are already always stripped anyway
so listing one specific fragment here is
unnecessary and potentially confusing.

This effectively reverts
4457928e32
but keeps the added bridgy testcase.
Fixes: #748
We have a bunch of mysterious sporadic failures which usually disappear
when rerunning failed jobs only. Ideally we should locate and fix the
cause of those psoradic failures, but until we figure this out retrying
once makes CI status less useless.
Currently `mix test` prints a slew of logs in the terminal
with messages from different tests intermsparsed. Globally
enabling capture log hides log messages unless a test fails
reducing noise and making it easier to anylse the important
(from failed tests) messages.

Compiler warnings and a few messages not printed via Logger
still show up but its much more readable than before.

Ported from: 3aed111a42
The debug logs are very noisy and can be enabled during analysis
of a specific error believed to be SQL-related

--

Before log capturing those debug messages were still hidden,
but with log capturing they show up in the output of failed
tests unless disabled.

Cherry-picked-from: e628d00a81
Multiple profiles can be specified as a space-separated list
and the possibility of additional profiles is explicitly brought up
in ActivityStream spec
Mastodon API demands this be null unless it’s a multi-selection poll.
Not abiding by this can mess up display in some clients.

Fixes: #190
Fix swagger-ui
Some checks are pending
ci/woodpecker/pr/build-amd64 Pipeline is pending
Details
ci/woodpecker/pr/build-arm64 Pipeline is pending
Details
ci/woodpecker/pr/docs Pipeline is pending
Details
ci/woodpecker/pr/lint Pipeline is pending
Details
ci/woodpecker/pr/test Pipeline is pending
Details
18f3297d4c 
Ever since the browser frontend switcher was introduced in
de64c6c54a /akkoma counts as
an API prefix and thus gets skipped by frontend plugs
breaking the old swagger ui path of /akkoma/swagger-ui.

Do the simple thing and change the frontend path to
/pleroma/swaggerui which isn't an API path and can't collide
with frontend user paths given pleroma is areserved nickname.

Reported in
  https://meta.akkoma.dev/t/view-all-endpoints/269/7
  https://meta.akkoma.dev/t/swagger-ui-not-loading/728
Oneric force-pushed varfixes from 18f3297d4c to 693e59461a 2024-06-21 16:46:16 +00:00 Compare
Oneric force-pushed varfixes from 693e59461a to 295430129d 2024-06-27 16:31:04 +00:00 Compare
Oneric force-pushed varfixes from 295430129d to a3101a435b 2024-06-27 23:36:58 +00:00 Compare
All checks were successful
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/build-amd64 Pipeline was successful
Details
ci/woodpecker/pr/build-arm64 Pipeline was successful
Details
ci/woodpecker/pr/docs Pipeline was successful
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u varfixes:Oneric-varfixes
git checkout Oneric-varfixes
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#814
No description provided.
Delete branch "Oneric/akkoma:varfixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?