AkkomaGang/akkoma
AkkomaGang/akkoma
15
65
Fork 92
Code Issues 176 Pull requests 24 Projects 2 Releases 14 Packages Wiki Activity

update nsfwCensorImage suggestion in config/description.exs #837

Open
norm wants to merge 1 commit from norm/akkoma:update-nsfwCensorImage into develop
pull from: norm/akkoma:update-nsfwCensorImage
merge into: AkkomaGang:develop
Conversation 2 Commits 1 Files changed 1 +2 -2
norm commented 2024-10-17 06:45:20 +00:00
Contributor
Copy link

Turns out this is also used to set the default values in adminfe, so
update this to the correct URL for the NSFW banner so that it doesn't
break if you reset this value.

Turns out this is also used to set the default values in adminfe, so update this to the correct URL for the NSFW banner so that it doesn't break if you reset this value.
norm added 1 commit 2024-10-17 06:45:21 +00:00
update nsfwCensorImage suggestion in config/description.exs
Some checks are pending
ci/woodpecker/pr/build-amd64 Pipeline is pending
Details
ci/woodpecker/pr/build-arm64 Pipeline is pending
Details
ci/woodpecker/pr/docs Pipeline is pending
Details
ci/woodpecker/pr/lint Pipeline is pending
Details
ci/woodpecker/pr/test Pipeline is pending
Details
be692e3a59 
Turns out this is also used to set the default values in adminfe, so
update this to the correct URL for the NSFW banner so that it doesn't
break if you reset this value.
Oneric commented 2024-10-17 21:33:32 +00:00
Member
Copy link

It seems like the hex id bit gets generated at frontend build time. Not sure what caused it to change, but it might be more future proof to leave suggestions empty just letting the frontend’s default fallback select the currently correct path

The base file in the frontend repo is src/assets/nsfw.png and it’s included as import nsfwImage from '../../assets/nsfw.png' in src/components/attachment/attachment.js for use as the default fallback

It seems like the hex id bit gets generated at frontend build time. Not sure what caused it to change, but it might be more future proof to leave suggestions empty just letting the frontend’s default fallback select the currently correct path The base file in the frontend repo is `src/assets/nsfw.png` and it’s included as `import nsfwImage from '../../assets/nsfw.png'` in `src/components/attachment/attachment.js` for use as the default fallback
norm force-pushed update-nsfwCensorImage from be692e3a59 to e4332d06b5 2024-10-20 05:01:47 +00:00 Compare
norm commented 2024-10-20 05:02:37 +00:00
Author
Contributor
Copy link

Setting the default URL to a blank string instead so it will indeed use the fallback set in the FE

Setting the default URL to a blank string instead so it will indeed use the fallback set in the FE
Oneric approved these changes 2024-10-26 21:55:56 +00:00
Some checks are pending
ci/woodpecker/pr/build-amd64 Pipeline is pending
Details
ci/woodpecker/pr/build-arm64 Pipeline is pending
Details
ci/woodpecker/pr/docs Pipeline is pending
Details
ci/woodpecker/pr/lint Pipeline is pending
Details
ci/woodpecker/pr/test Pipeline is pending
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u update-nsfwCensorImage:norm-update-nsfwCensorImage
git checkout norm-update-nsfwCensorImage
Sign in to join this conversation.
Reviewers
No reviewers
Oneric
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#837
No description provided.
Delete branch "norm/akkoma:update-nsfwCensorImage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?