AkkomaGang/akkoma
AkkomaGang/akkoma
15
66
Fork 94
Code Issues 176 Pull requests 15 Projects 2 Releases 16 Packages Wiki Activity

Completely omit id for anonymous objects #850

Merged
floatingghost merged 1 commit from Oneric/akkoma:ap-anonymous-errata into develop 2025-01-03 15:23:03 +00:00
Conversation 2 Commits 1 Files changed 3 +1 -4
Oneric commented 2024-11-10 01:52:31 +00:00
Member
Copy link

Although current behaviour is (the only way to) follow ActivityPub specification, the specification itself is buggy and incompatible with the JSON-LD spec its (transitively) based on. In practice following current spec creates federation issues with implementations performing JSON-LD processing, like e.g. IceShrimp.NET.

The bug was brought up with W3C and to remedy the situation a AP spec amendment/errata was proposed; this patch brings us in line with the proposed spec change, fixing: #848

WIP since federation effects are completely untested atm and the decision wrt AP spec isn’t final yet

Although current behaviour is (the only way to) follow ActivityPub specification, the specification itself is buggy and incompatible with the JSON-LD spec its (transitively) based on. In practice following current spec creates federation issues with implementations performing JSON-LD processing, like e.g. IceShrimp.NET. The bug was brought up with W3C and to remedy the situation a AP spec amendment/errata was proposed; this patch brings us in line with the proposed spec change, fixing: https://akkoma.dev/AkkomaGang/akkoma/issues/848 ~~**WIP** since federation effects are completely untested atm and the decision wrt AP spec isn’t final yet~~
👍 1
Oneric added 1 commit 2024-11-10 01:52:31 +00:00
Completely omit id for anonymous objects
Some checks are pending
ci/woodpecker/pr/build-amd64 Pipeline is pending approval
Details
ci/woodpecker/pr/build-arm64 Pipeline is pending approval
Details
ci/woodpecker/pr/docs Pipeline is pending approval
Details
ci/woodpecker/pr/lint Pipeline is pending approval
Details
ci/woodpecker/pr/test Pipeline is pending approval
Details
ci/woodpecker/pull_request_closed/build-amd64 Pipeline is pending approval
Details
ci/woodpecker/pull_request_closed/docs Pipeline is pending approval
Details
ci/woodpecker/pull_request_closed/lint Pipeline is pending approval
Details
ci/woodpecker/pull_request_closed/build-arm64 Pipeline is pending approval
Details
ci/woodpecker/pull_request_closed/test Pipeline is pending approval
Details
0f9c9aac38 
Current AP spec demands anonymous objects to have an id value,
but explicitly set it to JSON null. Howeveras it turns out this is
incompatible with JSON-LD requiring `@id` to be a string and thus AP
spec is incompatible iwth the Ativity Streams spec it is based on.
This is an issue for (the few) AP implementers actually performing
JSON-LD processing, like IceShrimp.NET.
This was uncovered by IceShrimp.NET’s zotan due to our adoption of
anonymous objects for emoj in f101886709.

The issues is being discussed by W3C, and will most likely be resolved
via an errata redefining anonymous objects to completely omit the id
field just like transient objects already do. See:
https://github.com/w3c/activitypub/issues/476

Fixes: #848
Oneric commented 2024-11-14 17:54:40 +00:00
Author
Member
Copy link

Federation test results:

Confirmed good:

  • Akkoma
  • IceShrimp.NET
  • Mastodon
  • Sharkey
Presumed good, but no confirmation:
  • Pleroma
Confirmed subpar, but still receiving all posts etc:
  • GTS (only showing text, no image)

This restores federation with IceShrimp.NET (and any other JSON-LD-processing implementations) and otherwise appears is no worse than before. With how the discussion in the W3C issue is going it also seems unlikely the effective result of the spec change will change from this, thus removing WIP; imho fairly safe and good to merge now

Federation test results: <strong>Confirmed good:</strong><br /> <ul> <li>Akkoma</li> <li>IceShrimp.NET</li> <li>Mastodon</li> <li>Sharkey</li> </ul> <strong>Presumed good, but no confirmation:</strong><br /> <ul> <li>Pleroma</li> </ul> <strong>Confirmed subpar, but still receiving all posts etc:</strong><br /> <ul> <li>GTS <i>(only showing text, no image)</i></li> </ul> This restores federation with IceShrimp.NET (and any other JSON-LD-processing implementations) and otherwise appears is no worse than before. With how the discussion in the W3C issue is going it also seems unlikely the effective result of the spec change will change from this, thus removing WIP; imho fairly safe and good to merge now
Oneric changed title from WIP: Completely omit id for anonymous objects to Completely omit id for anonymous objects 2024-11-14 17:55:04 +00:00
hongminhee approved these changes 2024-12-31 16:48:46 +00:00
hongminhee commented 2024-12-31 16:53:44 +00:00
First-time contributor
Copy link

The bug that this patch addresses causes interoperability issues between Akkoma and any Fedify-based implementations (including Hollo). I hope this patch will be merged soon!

The bug that this patch addresses causes [interoperability issues](https://github.com/dahlia/hollo/issues/86) between Akkoma and any [Fedify](https://fedify.dev/)-based implementations (including [Hollo](https://docs.hollo.social/)). I hope this patch will be merged soon!
floatingghost merged commit 91bedcfa68 into develop 2025-01-03 15:23:03 +00:00
floatingghost deleted branch ap-anonymous-errata 2025-01-03 15:23:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
hongminhee
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#850
No description provided.
Delete branch "Oneric/akkoma:ap-anonymous-errata"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?