FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

muted threads still produce notifications #12

New issue
Closed
opened 2022-07-13 22:48:39 +00:00 by norm · 4 comments
norm commented 2022-07-13 22:48:39 +00:00
Owner
Copy link

Currently muting a conversation with a poll will still generate vote notifications.

The upstream issue has yet to be fixed, so we should try to do so here.

Above was moved to #13.

The backend should not issue notifications for threads which are muted. This is already discussed more in this Misskey issue, where it was suggested to be able to give more detailed settings for which notifications from a thread should be muted.

~~Currently muting a conversation with a poll will still generate vote notifications.~~ ~~The [upstream issue](https://github.com/misskey-dev/misskey/issues/8102) has yet to be fixed, so we should try to do so here.~~ Above was moved to #13. The backend should not issue notifications for threads which are muted. This is already discussed more in [this Misskey issue](https://github.com/misskey-dev/misskey/issues/8102), where it was suggested to be able to give more detailed settings for which notifications from a thread should be muted.
👍 3
norm changed title from mute polls to muted thread still produces pollVote notification 2022-07-13 23:03:08 +00:00
toast added this to the (deleted) project 2022-07-13 23:16:50 +00:00
pixeldesu commented 2022-07-14 07:10:03 +00:00
Owner
Copy link

afaik the problem lies within misskey-js, not Misskey itself. We would need to fork that and use our fork in Foundkey to fix that issue.

the only thing missing from fixing it is syuilo tagging a release because the relevant change is already there.

afaik the problem lies within misskey-js, not Misskey itself. We would need to fork that and use our fork in Foundkey to fix that issue. the only thing missing from fixing it is syuilo tagging a release because the [relevant change is already there](https://github.com/misskey-dev/misskey.js/commit/c17c42fa05bcbcc38c7a4395d1bb3d2336d3d402).
Johann150 commented 2022-07-14 07:32:40 +00:00
Owner
Copy link

I think you are mixing up two issues here:

  • muted threads still produce notifications (I think that is what this issue is about)
  • notifications for ended polls can not be configured
I think you are mixing up two issues here: - muted threads still produce notifications (I think that is what this issue is about) - notifications for ended polls can not be configured
pixeldesu commented 2022-07-14 07:57:56 +00:00
Owner
Copy link

ah, my bad!

ah, my bad!
Johann150 changed title from muted thread still produces pollVote notification to muted threads still produce notifications 2022-07-14 08:22:04 +00:00
toast commented 2022-07-15 23:27:01 +00:00
Owner
Copy link

misskey-js should probably be integrated into the foundkey repo so we can have code sharing 🤔

misskey-js should probably be integrated into the foundkey repo so we can have code sharing 🤔
norm closed this issue 2022-09-22 19:52:33 +00:00
Johann150 added the
fix
 label 2022-12-23 10:19:57 +00:00
Johann150 removed this from the (deleted) project 2022-12-23 10:19:59 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
refactor-deliver-actor
markdown
move-autoblock
feature/requests
context
indicator-circle-v2
v13.0.0-preview6
v13.0.0-preview5.1
v13.0.0-preview5
v13.0.0-preview4
v13.0.0-preview3
v13.0.0-preview2
v13.0.0-preview1
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#12
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?