muted threads still produce notifications #12

New Issue

Closed

opened 2022-07-13 22:48:39 +00:00 by norm · 4 comments

norm commented

2022-07-13 22:48:39 +00:00

Owner

~~Currently muting a conversation with a poll will still generate vote notifications.~~

~~The upstream issue has yet to be fixed, so we should try to do so here.~~

Above was moved to #13.

The backend should not issue notifications for threads which are muted. This is already discussed more in this Misskey issue, where it was suggested to be able to give more detailed settings for which notifications from a thread should be muted.

~~Currently muting a conversation with a poll will still generate vote notifications.~~ ~~The [upstream issue](https://github.com/misskey-dev/misskey/issues/8102) has yet to be fixed, so we should try to do so here.~~ Above was moved to #13. The backend should not issue notifications for threads which are muted. This is already discussed more in [this Misskey issue](https://github.com/misskey-dev/misskey/issues/8102), where it was suggested to be able to give more detailed settings for which notifications from a thread should be muted.

👍 3

norm changed title from ~~mute polls~~ to muted thread still produces pollVote notification

2022-07-13 23:03:08 +00:00

toast added this to the (deleted) project 2022-07-13 23:16:50 +00:00

pixeldesu commented

2022-07-14 07:10:03 +00:00

Owner

afaik the problem lies within misskey-js, not Misskey itself. We would need to fork that and use our fork in Foundkey to fix that issue.

the only thing missing from fixing it is syuilo tagging a release because the relevant change is already there.

afaik the problem lies within misskey-js, not Misskey itself. We would need to fork that and use our fork in Foundkey to fix that issue. the only thing missing from fixing it is syuilo tagging a release because the [relevant change is already there](https://github.com/misskey-dev/misskey.js/commit/c17c42fa05bcbcc38c7a4395d1bb3d2336d3d402).

Johann150 commented

2022-07-14 07:32:40 +00:00

Owner

I think you are mixing up two issues here:

muted threads still produce notifications (I think that is what this issue is about)
notifications for ended polls can not be configured

I think you are mixing up two issues here: - muted threads still produce notifications (I think that is what this issue is about) - notifications for ended polls can not be configured

pixeldesu commented

2022-07-14 07:57:56 +00:00

Owner

ah, my bad!