Add misskey-js into main repo #24

New issue

Closed

opened 2022-07-22 18:50:06 +00:00 by norm · 2 comments

norm commented

2022-07-22 18:50:06 +00:00

Owner

Issues #12 and #13 rely on new things in misskey-js that are not part of a release yet. There's also the issue of redundant type definitions in the component code as well that should all be consolidated.

There is the option to just fork misskey.js into a separate repo, but this does mean having to cut new releases whenever we need to add in a new type definition or feature that relies on that library.

Instead, having it inside this repo will allow these changes to be done faster. This will require restructuring the FoundKey repo into a monorepo configuration. One way is by using Yarn Workspaces.

Issues #12 and #13 rely on new things in `misskey-js` that are not part of a release yet. There's also the issue of redundant type definitions in the component code as well that should all be consolidated. There is the option to just fork misskey.js into a separate repo, but this does mean having to cut new releases whenever we need to add in a new type definition or feature that relies on that library. Instead, having it inside this repo will allow these changes to be done faster. This will require restructuring the FoundKey repo into a monorepo configuration. One way is by using [Yarn Workspaces](https://yarnpkg.com/features/workspaces).

norm commented

2022-07-22 18:52:34 +00:00

Author

Owner

Having a monorepo will also be benenficial if we want to bring in mfm-js as well, though there isn't consensus yet about whether it'll continue to be used or if marked-mfm will be used instead.

Having a monorepo will also be benenficial if we want to bring in `mfm-js` as well, though there isn't consensus yet about whether it'll continue to be used or if [marked-mfm](https://akkoma.dev/sfr/marked-mfm) will be used instead.