GNU Social follow requests IDs do not fit in database model

helene commented

2022-09-12 00:18:11 +00:00

Contributor

GNU Social follow request IDs tend to be much longer than 128 characters and as such cannot fit within the database model's limit of 128 characters, which will cause the follow request to never be handled.

 	@Column('varchar', {
 		length: 128, nullable: true,
 		comment: 'id of Follow Activity.',
 	})
 	public requestId: string | null;

GNU Social follow request IDs tend to be much longer than 128 characters and as such cannot fit within the database model's limit of 128 characters, which will cause the follow request to never be handled. https://akkoma.dev/FoundKeyGang/FoundKey/src/commit/406be6b2136faa9232d8fcf7ecb6fcbfec20a8fe/packages/backend/src/models/entities/follow-request.ts#L42-L46 Related issue: https://github.com/misskey-dev/misskey/issues/9086

helene closed this issue

2022-09-12 00:18:44 +00:00

helene reopened this issue

2022-09-12 00:18:52 +00:00

norm commented

2022-09-12 00:36:20 +00:00

Owner

Know how big we can expect GNU Social's follow request IDs to be?

helene commented

2022-09-12 00:42:53 +00:00

Author

Contributor

Know how big we can expect GNU Social's follow request IDs to be?

The referenced issue is giving the following example:
https://gnusocial.jp/follow_from_https%3A%2F%2Fgnusocial.jp%2Findex.php%2Fuser%2F9200_to_https%3A%2F%2Fmewl.me%2Fusers%2F5b6bb2cada8b912b16218d34
So, pretty long, I'd say... 512 would probably be enough, I think, and most importantly would match what other entities have for ID length

> Know how big we can expect GNU Social's follow request IDs to be? The referenced issue is giving the following example: `https://gnusocial.jp/follow_from_https%3A%2F%2Fgnusocial.jp%2Findex.php%2Fuser%2F9200_to_https%3A%2F%2Fmewl.me%2Fusers%2F5b6bb2cada8b912b16218d34` So, pretty long, I'd say... 512 would probably be enough, I think, and most importantly would match what other entities have for ID length

👍 1

norm referenced this issue from a commit

2022-09-12 01:05:22 +00:00

backend: increase requestId max size for GNU Social

norm referenced this issue

2022-09-12 01:05:34 +00:00

backend: increase requestId max size for GNU Social #147

toast commented

2022-09-12 10:58:16 +00:00

Owner

URLs have a practical browser-limit of around 2000 chars, and 2048 chars in XML sitemaps' <loc>.
As such, I think making any URL-related fields that we receive from remote to be varchar(2048) is reasonable.
Besides that, all non-remote text fields should likely be TEXT, which is "immeasurably faster" according to postgres devs (and as discussed in irc).

URLs have a practical browser-limit of around 2000 chars, and 2048 chars in XML sitemaps' `<loc>`. As such, I think making any URL-related fields that we receive from remote to be `varchar(2048)` is reasonable. Besides that, all non-remote text fields should likely be TEXT, which is "immeasurably faster" according to postgres devs (and as discussed in irc).

norm referenced this issue from a commit

2022-09-12 14:39:25 +00:00

backend: increase requestId max size for GNU Social

norm referenced this issue

2022-09-12 14:40:43 +00:00

backend: increase requestId max size for GNU Social #147

norm referenced this issue from a commit

2022-09-12 15:10:59 +00:00

backend: increase requestId max size for GNU Social

norm referenced this issue from a commit

2022-09-12 15:39:21 +00:00

backend: increase requestId max size for GNU Social