FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

backend: increase requestId max size for GNU Social #147

Merged
norm merged 2 commits from fix/gnusocial-follow-request-ids into main 2022-09-12 17:48:37 +00:00
Conversation 1 Commits 2 Files changed 3 +19 -2
norm commented 2022-09-12 01:05:34 +00:00
Owner
Copy link

GNU Social's follow request IDs are larger than the 128 character limit
of the follow_request.requestId column. This prevents follow requests
from GNU Social instances from being handled by Foundkey instances.

The solution is to make the requestId column larger.

Fixes #146

GNU Social's follow request IDs are larger than the 128 character limit of the follow_request.requestId column. This prevents follow requests from GNU Social instances from being handled by Foundkey instances. The solution is to make the requestId column larger. Fixes https://akkoma.dev/FoundKeyGang/FoundKey/issues/146
norm force-pushed fix/gnusocial-follow-request-ids from 81d9c03118 to e82c3ce7a4 2022-09-12 14:39:25 +00:00 Compare
norm commented 2022-09-12 14:40:43 +00:00
Author
Owner
Copy link

As said by @toast in #146 (comment), I changed the column to be a VARCHAR(2048) as that's the practical limit for URL lengths.

As said by @toast in https://akkoma.dev/FoundKeyGang/FoundKey/issues/146#issuecomment-3248, I changed the column to be a `VARCHAR(2048)` as that's the practical limit for URL lengths.
norm force-pushed fix/gnusocial-follow-request-ids from e82c3ce7a4 to 7dd46513b1 2022-09-12 15:11:00 +00:00 Compare
norm force-pushed fix/gnusocial-follow-request-ids from 7dd46513b1 to 1120b6959d 2022-09-12 15:39:22 +00:00 Compare
Johann150 added 1 commit 2022-09-12 16:31:04 +00:00
limit id length of all incoming activities
Some checks failed
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline failed
Details
7ceb96b148
Johann150 approved these changes 2022-09-12 17:13:22 +00:00
Johann150 left a comment
Owner
Copy link

Following between too Misskey instances still works.

Following between too Misskey instances still works.
norm merged commit 193674ce03 into main 2022-09-12 17:48:37 +00:00
norm deleted branch fix/gnusocial-follow-request-ids 2022-09-12 17:48:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Johann150
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#147
No description provided.
Delete branch "fix/gnusocial-follow-request-ids"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?