fix: broken chats #16

norm · 2022-07-19T07:06:09Z

norm commented

2022-07-19 07:06:09 +00:00

From upstream PR: https://github.com/misskey-dev/misskey/pull/8983

norm added 2 commits 2022-07-19 07:06:10 +00:00

Fix broken chats 36503f63d8

Co-authored-by: @ltlapy

🎨 b803a7256b

norm added 1 commit 2022-07-19 07:08:53 +00:00

Merge branch 'main' into fix-chat-continuation 7d4cbd6ecf

Johann150 requested changes 2022-07-19 07:15:55 +00:00

Dismissed

packages/client/src/pages/messaging/messaging-room.vue

					
				@ -292,6 +292,7 @@ definePageMetadata(computed(() => !fetching ? user ? {

				<style lang="scss" scoped>

				.mk-messaging-room {

					position: relative;

					overflow: auto;

Johann150 commented

2022-07-19 07:15:48 +00:00

I think using overflow-y here is a better idea. Otherwise browsers will always show an unnecessary scroll bar for horizontal scrolling.

Or maybe use overflow: auto; instead to let the browser decide when scroll bars are necessary.
-- https://github.com/misskey-dev/misskey/pull/8951#discussion_r915101719

> I think using `overflow-y` here is a better idea. Otherwise browsers will always show an unnecessary scroll bar for horizontal scrolling. > > Or maybe use `overflow: auto;` instead to let the browser decide when scroll bars are necessary. -- https://github.com/misskey-dev/misskey/pull/8951#discussion_r915101719

Johann150 commented

2022-07-19 07:18:25 +00:00

Hang on that already says overflow auto...

Johann150 marked this conversation as resolved

Johann150 dismissed Johann150's review 2022-07-19 07:18:49 +00:00

Reason:

outdated

Johann150 referenced this pull request from a commit

2022-07-19 07:21:16 +00:00

fix appending to pagination component

Johann150 manually merged commit 9e90d2195f into main

2022-07-19 07:21:17 +00:00