FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

fix: broken chats #16

Manually merged
Johann150 merged 3 commits from :fix-chat-continuation into main 2022-07-19 07:21:17 +00:00
Conversation 0 Commits 3 Files Changed 2 +18 -18
norm commented 2022-07-19 07:06:09 +00:00
Owner
Copy Link

From upstream PR: https://github.com/misskey-dev/misskey/pull/8983

From upstream PR: https://github.com/misskey-dev/misskey/pull/8983
norm added 2 commits 2022-07-19 07:06:10 +00:00
36503f63d8
Fix broken chats 
Co-authored-by: @ltlapy
norm added 1 commit 2022-07-19 07:08:53 +00:00
Johann150 requested changes 2022-07-19 07:15:55 +00:00
Dismissed
packages/client/src/pages/messaging/messaging-room.vue
@ -292,6 +292,7 @@ definePageMetadata(computed(() => !fetching ? user ? {
<style lang="scss" scoped>
.mk-messaging-room {
position: relative;
overflow: auto;
Johann150 commented 2022-07-19 07:15:48 +00:00
Owner
Copy Link

I think using overflow-y here is a better idea. Otherwise browsers will always show an unnecessary scroll bar for horizontal scrolling.

Or maybe use overflow: auto; instead to let the browser decide when scroll bars are necessary.
-- https://github.com/misskey-dev/misskey/pull/8951#discussion_r915101719

> I think using `overflow-y` here is a better idea. Otherwise browsers will always show an unnecessary scroll bar for horizontal scrolling. > > Or maybe use `overflow: auto;` instead to let the browser decide when scroll bars are necessary. -- https://github.com/misskey-dev/misskey/pull/8951#discussion_r915101719
Johann150 commented 2022-07-19 07:18:25 +00:00
Owner
Copy Link

Hang on that already says overflow auto...

Hang on that already says overflow auto...
Johann150 marked this conversation as resolved
Johann150 dismissed Johann150’s review 2022-07-19 07:18:49 +00:00
Reason:

outdated

Johann150 manually merged commit 9e90d2195f into main 2022-07-19 07:21:17 +00:00
norm deleted branch fix-chat-continuation 2022-07-20 22:34:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#16
No description provided.
Delete Branch ":fix-chat-continuation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?