FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

WIP: client: remove blinking animation from notification indicator #172

Closed
toast wants to merge 2 commits from indicator-circle into main
pull from: indicator-circle
merge into: FoundKeyGang:main
Conversation 2 Commits 2 Files Changed 9 +3 -23
toast commented 2022-09-23 18:43:21 +00:00
Owner
Copy Link

It was annoying, and turns out, also a CPU hog!

Changelog: Removed

It was annoying, and turns out, also a CPU hog! Changelog: Removed
👍 1
toast added 1 commit 2022-09-23 18:43:22 +00:00
ci/woodpecker/push/lint-foundkey-js Pipeline was successful Details
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/push/lint-client Pipeline was successful Details
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/push/test Pipeline was successful Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful Details
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
2f570b11f1 client: remove blinking animation from notification indicator 
It was annoying, and turns out, also a CPU hog!

Changelog: Removed
toast commented 2022-09-23 18:43:29 +00:00
Author
Owner
Copy Link

WIP because I'm still testing.

WIP because I'm still testing.
norm commented 2022-10-03 20:46:01 +00:00
Owner
Copy Link

Works well for me, even seems to have gotten rid of the persistent dot on the Mentions tab when I clicked on it.

Works well for me, even seems to have gotten rid of the persistent dot on the Mentions tab when I clicked on it.
toast force-pushed indicator-circle from 2f570b11f1 to a7dbe09924 2022-10-17 01:20:22 +00:00 Compare
toast closed this pull request 2022-10-17 20:45:08 +00:00
Johann150 deleted branch indicator-circle 2022-10-18 17:31:53 +00:00
Some checks failed
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#172
No description provided.
Delete Branch "indicator-circle"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?