client: replace indicator circles #207

Open
toast wants to merge 2 commits from indicator-circle-v2 into main
Owner

Instead of indicator circles, we use colors and bold text.
The icon turns a doubly-saturated indicator color,
and the accompanying text (if any) turns bold.

In my limited testing, this works out very nicely aesthetically.
And it's much more lightweight!

Superseeds #172

Instead of indicator circles, we use colors and bold text. The icon turns a doubly-saturated indicator color, and the accompanying text (if any) turns bold. In my limited testing, this works out very nicely aesthetically. And it's much more lightweight! Superseeds #172
toast added 1 commit 2022-10-17 20:44:57 +00:00
client: replace indicator circles
Some checks failed
ci/woodpecker/push/lint-backend Pipeline was successful
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
ci/woodpecker/push/lint-client Pipeline was successful
ci/woodpecker/push/build Pipeline was successful
ci/woodpecker/push/test Pipeline was successful
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
ci/woodpecker/pr/lint-backend Pipeline was successful
ci/woodpecker/pr/build Pipeline was successful
ci/woodpecker/pr/lint-client Pipeline failed
ci/woodpecker/pr/test Pipeline failed
4d7531979f
Instead of indicator circles, we use colors and bold text.
The icon turns a doubly-saturated indicator color,
and the accompanying text (if any) turns bold.

In my limited testing, this works out very nicely aesthetically.
And it's much more lightweight!

Superseeds #172
ChangeLog: Changed
toast added 1 commit 2022-10-17 21:37:20 +00:00
fixup: missed a few elements in the div.text to span move
Some checks failed
ci/woodpecker/push/lint-client Pipeline was successful
ci/woodpecker/push/lint-backend Pipeline was successful
ci/woodpecker/push/build Pipeline was successful
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
ci/woodpecker/push/test Pipeline was successful
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
ci/woodpecker/pr/lint-backend Pipeline was successful
ci/woodpecker/pr/build Pipeline was successful
ci/woodpecker/pr/lint-client Pipeline failed
ci/woodpecker/pr/test Pipeline failed
473d2ffbb1
Owner

The color of the icons changed previously already, when you go to the respective page. I also cannot tell a difference between those colors on my screen using the Mi Dark theme.

The color of the icons changed previously already, when you go to the respective page. I also cannot tell a difference between those colors on my screen using the Mi Dark theme.
Author
Owner

The color of the icons changed previously already, when you go to the respective page.

This is a non-concern, since in theory, when you actually are on the page, the indicator should be off anyway.
Furthermore, the text is also bold (since only signaling something through color is considered bad practice).

I also cannot tell a difference between those colors on my screen using the Mi Dark theme.

Between the "active" and "indicated" colors, or between regular and indicated?
Because the latter should absolutely work.

> The color of the icons changed previously already, when you go to the respective page. This is a non-concern, since in theory, when you actually are on the page, the indicator should be off anyway. Furthermore, the text is also bold (since only signaling something through color is considered bad practice). > I also cannot tell a difference between those colors on my screen using the Mi Dark theme. Between the "active" and "indicated" colors, or between regular and indicated? Because the latter should absolutely work.
Owner

Maybe I should have mentioned that I use the top menu configuration. Here is a screenshot:
image

Maybe I should have mentioned that I use the top menu configuration. Here is a screenshot: ![image](/attachments/03e3b1df-e84e-4f2b-8de9-17900b5903f2)
Owner

Different screenshot when on the home timeline where the home symbol is the "normal" green.image

Different screenshot when on the home timeline where the home symbol is the "normal" green.![image](/attachments/612f6888-1c01-4269-a9bb-cbf889fb61ab)
8.8 KiB
Author
Owner

Oh, hm...
It's still not technically an issue, since you know what tab you're on now just by looking at the screen.
But yeah that's a bit more awkward.
I'll think about it.
Maybe I can add like a smol bar underneath the active one?

Oh, hm... It's still not technically an issue, since you know what tab you're on now just by looking at the screen. But yeah that's a bit more awkward. I'll think about it. Maybe I can add like a smol bar underneath the active one?
Some checks failed
ci/woodpecker/push/lint-client Pipeline was successful
ci/woodpecker/push/lint-backend Pipeline was successful
ci/woodpecker/push/build Pipeline was successful
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
ci/woodpecker/push/test Pipeline was successful
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
ci/woodpecker/pr/lint-backend Pipeline was successful
ci/woodpecker/pr/build Pipeline was successful
ci/woodpecker/pr/lint-client Pipeline failed
ci/woodpecker/pr/test Pipeline failed
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin indicator-circle-v2:indicator-circle-v2
git checkout indicator-circle-v2

Merge

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff indicator-circle-v2
git checkout indicator-circle-v2
git rebase main
git checkout main
git merge --ff-only indicator-circle-v2
git checkout indicator-circle-v2
git rebase main
git checkout main
git merge --no-ff indicator-circle-v2
git checkout main
git merge --squash indicator-circle-v2
git checkout main
git merge --ff-only indicator-circle-v2
git checkout main
git merge indicator-circle-v2
git push origin main
Sign in to join this conversation.
No reviewers
No labels
feature
fix
upkeep
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#207
No description provided.