Rip out unwanted features

toast commented

2022-07-08 22:26:42 +00:00

Owner

This is a tracking bug for the features we do not want.
Please discuss in #foundkey in irc.

To consider ripping out:

Confirmed for removal:

Advertisements
Promos (#62)

This is a tracking bug for the features we do not want. Please discuss in `#foundkey` in irc. To consider ripping out: Confirmed for removal: * [x] [Advertisements](https://akkoma.dev/FoundKeyGang/FoundKey/issues/3) * [x] Promos (https://akkoma.dev/FoundKeyGang/FoundKey/pulls/62)

Johann150 commented

2022-07-09 07:26:23 +00:00

Owner

I think we should consider removing the AI NSFW classification stuff:

Even if it is opt-in for admins, the dependencies have to be installed which means pulling in Tensorflow and all of its dependencies. Looking at the Misskey issue tracker, this has caused multiple problems.
There is nothing like an appeals process, so on the "hardest" settings it can just prevent the upload without being able to appeal.
I'm not convinced it works properly and/or can not be fooled easily anyway.
Maybe your instance should not be so big as to require automated moderation?

I think we should consider removing the AI NSFW classification stuff: 1. Even if it is opt-in for admins, the dependencies have to be installed which means pulling in Tensorflow and all of its dependencies. Looking at the Misskey issue tracker, this has caused multiple problems. 2. There is nothing like an appeals process, so on the "hardest" settings it can just prevent the upload without being able to appeal. 3. I'm not convinced it works properly and/or can not be fooled easily anyway. 4. Maybe your instance should not be so big as to require automated moderation?

👍 4

toast commented

2022-07-09 10:17:35 +00:00

Author

Owner

I don't think the AI stuff isn't even in this tree to begin with - so I just won't merge it ^^;;
I forked out before the PR got added in.
If I'm wrong and it is in, it's 100% getting ripped out.

I don't think the AI stuff isn't even in this tree to begin with - so I just won't merge it ^^;; I forked out before the PR got added in. If I'm wrong and it is in, it's 100% getting ripped out.

👍 1 🎉 3

Ghost commented

2022-07-09 13:00:06 +00:00

small nitpick but maybe the Search => Google localization change, which was just a petty commit by syuilo following the discourse about the lack of search engine configuration

small nitpick but maybe the `Search` => `Google` localization change, which was just a petty commit by syuilo following the discourse about the lack of search engine configuration

👍 1

Johann150 commented

2022-07-09 13:54:01 +00:00

Owner

While doing that could also make the button either use the note search or just do nothing.

[2022-07-09 13:34:15Z] <toast> I kind of like the "useless button" thing actually

While doing that could also make the button either use the note search or just do nothing. ```irc [2022-07-09 13:34:15Z] <toast> I kind of like the "useless button" thing actually ```

👍 1 🚀 1

ente commented

2022-07-11 04:21:19 +00:00

Very small change:

There is this "Advertisment" function in the Admins view.
Maybe one small thng to consider to get rid of with very low priority.

Haven't seen that anyone uses it besides a little bit of fun...

Very small change: There is this "Advertisment" function in the Admins view. Maybe one small thng to consider to get rid of with very low priority. Haven't seen that anyone uses it besides a little bit of fun...

👍 2

Ghost commented

2022-07-11 07:59:23 +00:00

maybe get rid of the builtin "notification" slide animation in favor of actual web push notifications? or at least make it a toggle

Johann150 referenced this issue

2022-07-11 10:25:02 +00:00

Remove advertisement functionality #3

toast commented

2022-07-11 16:02:09 +00:00

Author

Owner

maybe get rid of the builtin "notification" slide animation in favor of actual web push notifications? or at least make it a toggle

I'd consider that more of a "new feature" situation.
Definitely something I want to do, though!

> maybe get rid of the builtin "notification" slide animation in favor of actual web push notifications? or at least make it a toggle I'd consider that more of a "new feature" situation. Definitely something I want to do, though!

puniko commented

2022-08-07 09:13:40 +00:00

Contributor

While doing that could also make the button either use the note search or just do nothing.
[2022-07-09 13:34:15Z] <toast> I kind of like the "useless button" thing actually

i see some use of the search mfm button on my instance tho. i have linked it to my searx instance. probably would be nice to have it configurable in the long term (just my 2 cents)

> While doing that could also make the button either use the note search or just do nothing. > > ```irc > [2022-07-09 13:34:15Z] <toast> I kind of like the "useless button" thing actually > ``` i see some use of the search mfm button on my instance tho. i have linked it to my searx instance. probably would be nice to have it configurable in the long term (just my 2 cents)

Johann150 commented

2022-08-11 12:46:16 +00:00

Owner

I think the "promo notes" feature can be removed as well.

There is an API to create promo notes, but the menu entry to use that API endpoint in the web client is commented out:

 			/*
 		...($i.isModerator || $i.isAdmin ? [
 			null,
 			{
 				icon: 'fas fa-bullhorn',
 				text: i18n.ts.promote,
 				action: promote
 			}]
 			: []
 		),*/

The data is read in server/api/common/inject-promo.ts but I could not find a place where that file is included so it does not seem to even be used.

I think the "promo notes" feature can be removed as well. There is an API to create promo notes, but the menu entry to use that API endpoint in the web client is commented out: https://akkoma.dev/FoundKeyGang/FoundKey/src/commit/534666f762e970197fa1fde5495aa5fb575eb256/packages/client/src/scripts/get-note-menu.ts#L275-L284 The data is read in `server/api/common/inject-promo.ts` but I could not find a place where that file is included so it does not seem to even be used.

👍 2

Johann150 commented

2022-08-11 13:07:31 +00:00

Owner

I guess this is a predecessor or at least its similar to ads so I don't think we'd have big regrets throwing it out.

The client side has been commented out since commit 14fa8b177d (2021-12-02). The server side of using injectPromo has been removed since commit 73df95c42d (2021-03-20). The commit message for server side says (translated):

Disable injectPromo and injectFeatured for client-side implementation

Apparently that client side implementation never happened and later the client side code was commented out.

I guess this is a predecessor or at least its similar to ads so I don't think we'd have big regrets throwing it out. The client side has been commented out since commit 14fa8b177d4520695a54f6ab52e498f9b9370a5d (2021-12-02). The server side of using `injectPromo` has been removed since commit 73df95c42d98c38d362e02a79c5d7620a06f6633 (2021-03-20). The commit message for server side says (translated): > Disable `injectPromo` and `injectFeatured` for client-side implementation Apparently that client side implementation never happened and later the client side code was commented out.

👍 2

norm referenced this issue from a commit

2022-08-28 14:46:46 +00:00

Merge pull request #2 from misskey-dev/work/project-1

Johann150 commented

2022-12-14 23:18:22 +00:00

Owner

I don't think there is a big point in keeping this issue open. If you think more features should be removed open a separate issue about it.

Johann150 closed this issue

2022-12-14 23:18:22 +00:00

Rip out unwanted features #2