Remove advertisement functionality #3

New issue

Closed

opened 2022-07-11 10:25:02 +00:00 by Johann150 · 1 comment

Johann150 commented

2022-07-11 10:25:02 +00:00

Owner

Remove the funcitonality to show advertisements.

Suggested in #2 and on IRC:

[2022-07-09 14:07:24Z] <toast> any complaints about ripping ads out?
[2022-07-09 14:07:43Z] <norm> nope, never used them
[2022-07-09 14:07:56Z] <johann> nooo i wanted to use ads on my single user instance
[2022-07-09 14:07:59Z] <johann>  /s
[2022-07-09 14:08:15Z] <sfr> ads but only for logged out users
[2022-07-09 14:08:19Z] <johann> i only recall towo was using them to show old DB ads but i think more as a joke
[2022-07-09 14:08:35Z] <sfr> wouldn't be surprised if io is the only instance to use ads

remove API
remove database table
remove client logic (grep for e.g. _shouldInsertAd_)

Remove the funcitonality to show advertisements. Suggested in #2 and on IRC: ``` [2022-07-09 14:07:24Z] <toast> any complaints about ripping ads out? [2022-07-09 14:07:43Z] <norm> nope, never used them [2022-07-09 14:07:56Z] <johann> nooo i wanted to use ads on my single user instance [2022-07-09 14:07:59Z] <johann> /s [2022-07-09 14:08:15Z] <sfr> ads but only for logged out users [2022-07-09 14:08:19Z] <johann> i only recall towo was using them to show old DB ads but i think more as a joke [2022-07-09 14:08:35Z] <sfr> wouldn't be surprised if io is the only instance to use ads ``` - [x] remove API - [x] remove database table - [x] remove client logic (grep for e.g. `_shouldInsertAd_`)

Johann150 added this to the (deleted) project 2022-07-11 10:25:02 +00:00

Johann150 closed this issue

2022-07-11 10:41:26 +00:00

Johann150 reopened this issue

2022-07-11 10:41:30 +00:00

toast referenced this issue

2022-07-11 16:01:47 +00:00

Rip out unwanted features #2

toast commented

2022-07-11 16:02:52 +00:00

Owner

I'll try and look into this uh, whenever my next not-on-work-hours-and-I-don't-feel-dead period is ;-; (technically any work I do on dayjob hours is legally problematic)

Johann150 referenced this issue from a pull request that will close it,

2022-07-11 20:34:59 +00:00

remove ads #5

Johann150 closed this issue

2022-07-13 21:30:25 +00:00

Johann150 added the

fix

label 2022-12-23 10:19:48 +00:00

Johann150 removed this from the (deleted) project 2022-12-23 10:19:51 +00:00