different error images #281

Closed
m33 wants to merge 6 commits from m33/FoundKey:main into main
First-time contributor

This is my take to removing cat schoolgirls and external ressources.

Note: some ressources point to my fork, should point to original fk fork instead if/when merged.

This is my take to removing cat schoolgirls and external ressources. Note: some ressources point to my fork, should point to original fk fork instead if/when merged.
m33 added 6 commits 2022-12-11 19:06:03 +00:00
patch image from external site to foundkey repos
Some checks failed
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
ci/woodpecker/pr/lint-backend Pipeline failed
ci/woodpecker/pr/build Pipeline was successful
ci/woodpecker/pr/lint-client Pipeline failed
ci/woodpecker/pr/test Pipeline failed
70539d9d49
Johann150 requested changes 2022-12-11 19:29:53 +00:00
@ -76,3 +76,3 @@
await queryRunner.query(`CREATE INDEX "IDX_b11a5e627c41d4dc3170f1d370" ON "notification" ("createdAt") `);
await queryRunner.query(`CREATE INDEX "IDX_3c601b70a1066d2c8b517094cb" ON "notification" ("notifieeId") `);
await queryRunner.query(`CREATE TABLE "meta" ("id" character varying(32) NOT NULL, "name" character varying(128), "description" character varying(1024), "maintainerName" character varying(128), "maintainerEmail" character varying(128), "announcements" jsonb NOT NULL DEFAULT '[]', "disableRegistration" boolean NOT NULL DEFAULT false, "disableLocalTimeline" boolean NOT NULL DEFAULT false, "disableGlobalTimeline" boolean NOT NULL DEFAULT false, "enableEmojiReaction" boolean NOT NULL DEFAULT true, "useStarForReactionFallback" boolean NOT NULL DEFAULT false, "langs" character varying(64) array NOT NULL DEFAULT '{}'::varchar[], "hiddenTags" character varying(256) array NOT NULL DEFAULT '{}'::varchar[], "blockedHosts" character varying(256) array NOT NULL DEFAULT '{}'::varchar[], "mascotImageUrl" character varying(512) DEFAULT '/assets/ai.png', "bannerUrl" character varying(512), "errorImageUrl" character varying(512) DEFAULT 'https://xn--931a.moe/aiart/yubitun.png', "iconUrl" character varying(512), "cacheRemoteFiles" boolean NOT NULL DEFAULT true, "proxyAccount" character varying(128), "enableRecaptcha" boolean NOT NULL DEFAULT false, "recaptchaSiteKey" character varying(64), "recaptchaSecretKey" character varying(64), "localDriveCapacityMb" integer NOT NULL DEFAULT 1024, "remoteDriveCapacityMb" integer NOT NULL DEFAULT 32, "maxNoteTextLength" integer NOT NULL DEFAULT 500, "summalyProxy" character varying(128), "enableEmail" boolean NOT NULL DEFAULT false, "email" character varying(128), "smtpSecure" boolean NOT NULL DEFAULT false, "smtpHost" character varying(128), "smtpPort" integer, "smtpUser" character varying(128), "smtpPass" character varying(128), "enableServiceWorker" boolean NOT NULL DEFAULT false, "swPublicKey" character varying(128), "swPrivateKey" character varying(128), "enableTwitterIntegration" boolean NOT NULL DEFAULT false, "twitterConsumerKey" character varying(128), "twitterConsumerSecret" character varying(128), "enableGithubIntegration" boolean NOT NULL DEFAULT false, "githubClientId" character varying(128), "githubClientSecret" character varying(128), "enableDiscordIntegration" boolean NOT NULL DEFAULT false, "discordClientId" character varying(128), "discordClientSecret" character varying(128), CONSTRAINT "PK_c4c17a6c2bd7651338b60fc590b" PRIMARY KEY ("id"))`);
await queryRunner.query(`CREATE TABLE "meta" ("id" character varying(32) NOT NULL, "name" character varying(128), "description" character varying(1024), "maintainerName" character varying(128), "maintainerEmail" character varying(128), "announcements" jsonb NOT NULL DEFAULT '[]', "disableRegistration" boolean NOT NULL DEFAULT false, "disableLocalTimeline" boolean NOT NULL DEFAULT false, "disableGlobalTimeline" boolean NOT NULL DEFAULT false, "enableEmojiReaction" boolean NOT NULL DEFAULT true, "useStarForReactionFallback" boolean NOT NULL DEFAULT false, "langs" character varying(64) array NOT NULL DEFAULT '{}'::varchar[], "hiddenTags" character varying(256) array NOT NULL DEFAULT '{}'::varchar[], "blockedHosts" character varying(256) array NOT NULL DEFAULT '{}'::varchar[], "mascotImageUrl" character varying(512) DEFAULT '/assets/ai.png', "bannerUrl" character varying(512), "errorImageUrl" character varying(512) DEFAULT 'https://akkoma.dev/FoundKeyGang/FoundKey/raw/branch/main/assets/ai-orig.png', "iconUrl" character varying(512), "cacheRemoteFiles" boolean NOT NULL DEFAULT true, "proxyAccount" character varying(128), "enableRecaptcha" boolean NOT NULL DEFAULT false, "recaptchaSiteKey" character varying(64), "recaptchaSecretKey" character varying(64), "localDriveCapacityMb" integer NOT NULL DEFAULT 1024, "remoteDriveCapacityMb" integer NOT NULL DEFAULT 32, "maxNoteTextLength" integer NOT NULL DEFAULT 500, "summalyProxy" character varying(128), "enableEmail" boolean NOT NULL DEFAULT false, "email" character varying(128), "smtpSecure" boolean NOT NULL DEFAULT false, "smtpHost" character varying(128), "smtpPort" integer, "smtpUser" character varying(128), "smtpPass" character varying(128), "enableServiceWorker" boolean NOT NULL DEFAULT false, "swPublicKey" character varying(128), "swPrivateKey" character varying(128), "enableTwitterIntegration" boolean NOT NULL DEFAULT false, "twitterConsumerKey" character varying(128), "twitterConsumerSecret" character varying(128), "enableGithubIntegration" boolean NOT NULL DEFAULT false, "githubClientId" character varying(128), "githubClientSecret" character varying(128), "enableDiscordIntegration" boolean NOT NULL DEFAULT false, "discordClientId" character varying(128), "discordClientSecret" character varying(128), CONSTRAINT "PK_c4c17a6c2bd7651338b60fc590b" PRIMARY KEY ("id"))`);
Owner

It makes no sense to modify old migrations.

It makes no sense to modify old migrations.
@ -9,3 +9,3 @@
async down(queryRunner) {
await queryRunner.query(`ALTER TABLE "meta" ADD "mascotImageUrl" character varying(512) DEFAULT '/assets/ai.png'`);
await queryRunner.query(`ALTER TABLE "meta" ADD "errorImageUrl" character varying(512) DEFAULT 'https://xn--931a.moe/aiart/yubitun.png'`);
await queryRunner.query(`ALTER TABLE "meta" ADD "errorImageUrl" character varying(512) DEFAULT '/assets/ai-orig.png'`);
Owner

As above: No point in modifying past migrations.

As above: No point in modifying past migrations.
@ -36,1 +34,3 @@
link(rel='prefetch' href='https://xn--931a.moe/assets/error.jpg')
link(rel='prefetch' href='https://akkoma.dev/m33/FoundKey/raw/branch/main/assets/ai-info.png')
link(rel='prefetch' href='https://akkoma.dev/m33/FoundKey/raw/branch/main/assets/ai-not-found.png')
link(rel='prefetch' href='https://akkoma.dev/m33/FoundKey/raw/branch/main/assets/ai-error.png')
Owner

For here and all the other places:

akkoma.dev is a gitea instance for hosting code and not a content delivery network. I don't think it is appropriate to serve static resources in our client from it.

For here and all the other places: `akkoma.dev` is a gitea instance for hosting code and not a content delivery network. I don't think it is appropriate to serve static resources in our client from it.
Owner

I think the better solution would be to have configurable error images.

I'm also not sure if the images in /assets/about are used at all, I think they were used in the README before. I'll look into that and remove them if they are not used.

I think the better solution would be to have configurable error images. I'm also not sure if the images in `/assets/about` are used at all, I think they were used in the README before. I'll look into that and remove them if they are not used.
Johann150 changed title from main to different error images 2022-12-11 19:33:08 +00:00
Author
First-time contributor

Don't know much more about how theses pics are actually in use, or not. How relevant is patching migration files and all.

All ressources should be self hosted, on one' instances and not this git depot indeed. But don't know how to point to self (not sure about relative path).

Don't know much more about how theses pics are actually in use, or not. How relevant is patching migration files and all. All ressources should be self hosted, on one' instances and not this git depot indeed. But don't know how to point to self (not sure about relative path).
Author
First-time contributor

Oh, and the robot pic comes from https://pixabay.com/fr/illustrations/mignonne-dessin-anim%C3%A9-robot-marrant-807306/ (https://pixabay.com/fr/users/bcogwene-1114581/?tab=about)
It seems totally free to use without royalties or attributions, but I guess some attribution to the author wouldn't hurt.

Oh, and the robot pic comes from https://pixabay.com/fr/illustrations/mignonne-dessin-anim%C3%A9-robot-marrant-807306/ (https://pixabay.com/fr/users/bcogwene-1114581/?tab=about) It seems totally free to use without royalties or attributions, but I guess some attribution to the author wouldn't hurt.
Owner

closed in favour of #282

closed in favour of #282
Johann150 closed this pull request 2022-12-12 19:40:47 +00:00
Some checks failed
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
ci/woodpecker/pr/lint-backend Pipeline failed
ci/woodpecker/pr/build Pipeline was successful
ci/woodpecker/pr/lint-client Pipeline failed
ci/woodpecker/pr/test Pipeline failed

Pull request closed

Sign in to join this conversation.
No reviewers
No labels
feature
fix
upkeep
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#281
No description provided.