Creating a new theme will lock out the theme page #353

New issue

Closed

opened 2023-03-09 12:57:09 +00:00 by EpicKitty · 1 comment

EpicKitty commented

2023-03-09 12:57:09 +00:00

Steps to reproduce

Navigate to the "Themes" section of settings
Click "Make a theme"
Fill out the desired information for the theme, this doesn't impact the bug
Press the "Save as" button and give it a name.
Press "Save" and then "Got it!"
Close the theme creation panel.
Navigate back to the "Themes" section of settings

From what I can see, doing these actions is setting the miux:darkTheme or miux:lightTheme value (depending on which you have selected) to undefined which then breaks the theme page when loading. To manually fix this, you can remove the specific KV from the local storage, refresh the page and then select the theme you want to use.

## Steps to reproduce 1. Navigate to the "Themes" section of settings 2. Click "Make a theme" 3. Fill out the desired information for the theme, this doesn't impact the bug 4. Press the "Save as" button and give it a name. 5. Press "Save" and then "Got it!" 6. Close the theme creation panel. 7. Navigate back to the "Themes" section of settings From what I can see, doing these actions is setting the `miux:darkTheme` or `miux:lightTheme` value (depending on which you have selected) to `undefined` which then breaks the theme page when loading. To manually fix this, you can remove the specific KV from the local storage, refresh the page and then select the theme you want to use.

Johann150 commented

2023-03-09 18:57:41 +00:00

Owner

It seem the error occurs when saving the theme (i.e. in step 5). There are two calls to ColdDeviceStorage.set, the first one is fine and the second one sets the value to undefined. I'm not sure where the 2nd call is happening. I'll try to look into this further when I have more time.

It seem the error occurs when saving the theme (i.e. in step 5). There are two calls to `ColdDeviceStorage.set`, the first one is fine and the second one sets the value to `undefined`. I'm not sure where the 2nd call is happening. I'll try to look into this further when I have more time.