Creating theme with theme editor locks out theme settings page, breaks theming entirely upon cache clear #376

New Issue

Closed

opened 2023-04-17 14:33:52 +00:00 by emilis · 1 comment

emilis commented

2023-04-17 14:33:52 +00:00

Steps to reproduce:

Go to Settings -> Themes
Click "Make a theme"
Click "Save As"
Name the theme and click OK
Return to Settings -> Themes

Expected result:
Theme page is loaded as normal.

Actual result:
Theme settings page fails to load, is left blank.

Additionally, if the "Clear Cache" button is pressed in settings, theming will be fully broken:

Manual fix:
Seems like the localstorage key miux:lightTheme (or miux:darkTheme if the theme was set to a dark theme prior) is being set to undefined after the above sequence of events. Deleting the value from localstorage and refreshing fixes the theme being broken (post-clear-cache) and restores the theme editor page.

**Steps to reproduce:** 1. Go to Settings -> Themes 2. Click "Make a theme" 3. Click "Save As" 4. Name the theme and click OK 5. Return to Settings -> Themes **Expected result:** Theme page is loaded as normal. **Actual result:** Theme settings page fails to load, is left blank. Additionally, if the "Clear Cache" button is pressed in settings, theming will be fully broken: ![image](/attachments/01daa033-9907-4152-97d9-c112657ac3b4) **Manual fix:** Seems like the localstorage key `miux:lightTheme` (or `miux:darkTheme` if the theme was set to a dark theme prior) is being set to `undefined` after the above sequence of events. Deleting the value from localstorage and refreshing fixes the theme being broken (post-clear-cache) and restores the theme editor page.

image.png

54 KiB